Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JsonExporter: make Json export more extensible. #2081

Merged
merged 1 commit into from
Aug 24, 2022
Merged

JsonExporter: make Json export more extensible. #2081

merged 1 commit into from
Aug 24, 2022

Conversation

ptr1120
Copy link
Contributor

@ptr1120 ptr1120 commented Aug 24, 2022

Hello,
I would like to add additional data to the existing JSON BenchmarkDotNet report, but there is currently no possibility to enrich the report. That's why I separated ExportToLog into report creation (ExportToLog) and further virtual report data generation methods (CreateLog).

Best regards
Peter

@adamsitnik Sorry for closing my initial pull request (#1915). I applied your suggested change (Rename CreateLog-> GetDataToSerialize) and had an issue rebasing this change into my initial commit.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ptr1120 thank you again!

@adamsitnik adamsitnik merged commit a11b49a into dotnet:master Aug 24, 2022
@adamsitnik
Copy link
Member

btw speaking of #1915: I've solved the merge conflict via GitHub website, this has pushed some changes to your fork and when you tried to rename the method you most probably got rejected and force pushed. The best way to avoid such issues is to always create a new branch for every PR. Then if the PR gets rejected or the something bad happens with git your main branch remains clean and you can create a new one.

How to create a new branch:

git checkout -b $newBranchName

How to sync your branch:

git remote add upstream https://github.com/dotnet/BenchmarkDotNet
git fetch upstream
git merge upstream/master

@ptr1120
Copy link
Contributor Author

ptr1120 commented Aug 24, 2022

@adamsitnik thanks for the explanation.

@AndreyAkinshin AndreyAkinshin added this to the v0.13.2 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants