Amend SummaryStyle to support visualization of '0' in reports #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract CreateSummary method for benchmarks with metrics - Extract FakeMetricDescriptor into separate file
- CsvExporter now prints '0' instead of '-' in the report - Add PrintZeroValuesInContent option in SummaryStyle to control it (by default it is false) - Add tests to cover changed behavior Closes dotnet#1168
|
|
|
@sleemer thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use generated csv reports for publishing results to TSDB (e.g. Influx) we need to change the way '0' are visualized. By default they are dashed '-'. The goal of this PR is to change it for CsvExporter, but leave it as it is for the other exporters (console/GH/HTML).
Addresses #1168