Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log shows a wrong name for plot images #1181

Closed
simonech opened this issue Jun 23, 2019 · 11 comments
Closed

Log shows a wrong name for plot images #1181

simonech opened this issue Jun 23, 2019 · 11 comments
Milestone

Comments

@simonech
Copy link

simonech commented Jun 23, 2019

After running a benchmark with [RPlotExporter] I get zillions of jpg files, but I'm not sure all of them have the correct name.

First of all, the log in the console says:

// * Export *
  BenchmarkDotNet.Artifacts/results/MyBench.Sleeps-report.csv
  BenchmarkDotNet.Artifacts/results/MyBench.Sleeps-report-github.md
  BenchmarkDotNet.Artifacts/results/MyBench.Sleeps-report.html
  BenchmarkDotNet.Artifacts/results/MyBench.Sleeps-measurements.csv
  BuildPlots.R
  BenchmarkDotNet.Artifacts/results/MyBench.Sleeps-20190623-012647-boxplot.png
  BenchmarkDotNet.Artifacts/results/MyBench.Sleeps-20190623-012647-barplot.png

But the files stored in the artifacts folder are called MyBench.Sleeps-barplot.png and MyBench.Sleeps-boxplot.png (so, they don't have the timestamp).

@AndreyAkinshin
Copy link
Member

@simonech thanks for the report!

@simonech
Copy link
Author

simonech commented Jun 23, 2019

@AndreyAkinshin I could have a look at the first, since it's an issue in the .net code.
The second is generated in the R script, and I've no idea how that works 😄

maybe it would be better to split the issue in two issues

@AndreyAkinshin
Copy link
Member

@simonech

I could have a look at the first, since it's an issue in the .net code.

Great, thanks! It should be pretty easy to fix.

maybe it would be better to split the issue in two issues

OK. Do you want to create another issue for the second problem (and edit the current one)?

@simonech
Copy link
Author

simonech commented Jun 24, 2019

@simonech

I could have a look at the first, since it's an issue in the .net code.

Great, thanks! It should be pretty easy to fix.

Indeed... I'll do it

maybe it would be better to split the issue in two issues

OK. Do you want to create another issue for the second problem (and edit the current one)?

Yeah, I've created a new ticket with the second part of the issue (#1183)

@simonech simonech changed the title The filename of some plots is wrong Log shows a wrong name for plot images Jun 24, 2019
@AndreyAkinshin
Copy link
Member

Great, thanks! Waiting for a PR. =)

@marcnet80
Copy link
Contributor

Hi, @AndreyAkinshin. Could you please provide steps to reproduce this issue?
Maybe this behaviour relates to this line: https://github.com/dotnet/BenchmarkDotNet/blob/master/src/BenchmarkDotNet/Exporters/ExporterBase.cs#L34

@AndreyAkinshin
Copy link
Member

@marcnet80 just run any benchmark with the [RPlotExplorter] attribute.
Since RPlotExporter generates a lot of different plots (not only boxplot and barplot) and there is no a simple way to get real names of these files (this logic is controlled by the internals of BuildPlots.R), I suggest to print just *.png instead of specific names.

@marcnet80
Copy link
Contributor

@AndreyAkinshin, all generates plots have png extension?

@AndreyAkinshin
Copy link
Member

@marcnet80 yes.

@marcnet80
Copy link
Contributor

Ok. I will create pull-request today. Thank you.

marcnet80 pushed a commit to marcnet80/BenchmarkDotNet that referenced this issue Aug 2, 2019
marcnet80 added a commit to marcnet80/BenchmarkDotNet that referenced this issue Aug 6, 2019
marcnet80 added a commit to marcnet80/BenchmarkDotNet that referenced this issue Aug 6, 2019
AndreyAkinshin pushed a commit to marcnet80/BenchmarkDotNet that referenced this issue Sep 6, 2019
AndreyAkinshin pushed a commit to marcnet80/BenchmarkDotNet that referenced this issue Sep 6, 2019
@adamsitnik
Copy link
Member

Fixed a long time ago in #1217, closing

@adamsitnik adamsitnik added this to the v0.12.0 milestone Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants