Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IP address format with note #8449

Merged
merged 4 commits into from
Sep 7, 2018
Merged

Update IP address format with note #8449

merged 4 commits into from
Sep 7, 2018

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Sep 7, 2018

Addresses #8417

@guardrex guardrex requested a review from Tratcher September 7, 2018 16:32
@guardrex guardrex requested a review from scottaddie September 7, 2018 16:40
@guardrex
Copy link
Collaborator Author

guardrex commented Sep 7, 2018

@scottaddie I'm on the fence about the † ... Should I inline this text between the bullet list and the code example?

If we want to de-emphasize the points, let's keep them in footnote format. If we want to emphasize those points, then I'd say let's move those two sentences just above the code example (and de-dagger them).

@scottaddie
Copy link
Member

@guardrex Please move the points just above the code example and de-dagger them.

@guardrex guardrex merged commit 21ff93d into master Sep 7, 2018
@guardrex guardrex deleted the guardrex-patch-1 branch September 7, 2018 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants