Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surface XML array indexing for Configuration #5488

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Surface XML array indexing for Configuration #5488

merged 1 commit into from
Feb 21, 2018

Conversation

guardrex
Copy link
Collaborator

React to aspnet/Configuration#770

@HaoK Would u like to address that in the topic? It's true that if one tries to do this ...

Configuration["wizard:1:age"]

... it won't work with XML.

@guardrex guardrex requested a review from HaoK February 16, 2018 02:30
@guardrex
Copy link
Collaborator Author

ping @HaoK

@guardrex guardrex requested a review from scottaddie February 21, 2018 07:23
@guardrex
Copy link
Collaborator Author

Thanks @HaoK

@scottaddie "Meesa lik'in dis. Wha da ya tinks?" - Jar Jar Binks

@scottaddie scottaddie merged commit 64f1b22 into master Feb 21, 2018
@scottaddie scottaddie deleted the guardrex-patch-3 branch February 21, 2018 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK HaoK approved these changes

@scottaddie scottaddie scottaddie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guardrex @HaoK @scottaddie