Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor Server script fallback policy authorization #32035

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Mar 12, 2024

Fixes #31931

Thank you @CoskunSunali for that great write-up 🥇. I've combined your remarks with Stephen's response to address this subject in the Migration article. It's here for review if you would like to provide feedback 👂.

Stephen said on the issue ...

It looks like the documentation at https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/blazor/fundamentals/static-files.md ought to be updated to reflect that Blazor static files no longer rely on UseStaticFiles and instead are mapped using endpoint routing.

... but I think I need a more specific change set to update the article. I'm also not generally clear what "Blazor static files" means ... I don't think he meant that Static File Middleware no-ops in BWAs. I think he means that static assets managed by Blazor (the framework) are now (8.0+) mapped via endpoint routing. Anyway, a specific change set for the article would be helpful. I'd like to knock it out 🤜😵 on this PR if possible. If not tho ... I can open a new issue to address it later.


Internal previews

📄 File 🔗 Preview link
aspnetcore/migration/70-80.md Migrate from ASP.NET Core in .NET 7 to .NET 8

@guardrex guardrex requested a review from MackinnonBuck March 12, 2024 14:21
@guardrex guardrex self-assigned this Mar 12, 2024
@CoskunSunali
Copy link

Thank you @CoskunSunali for that great write-up 🥇. I've combined your remarks with Stephen's response to address this subject in the Migration article. It's here for review if you would like to provide feedback 👂.

Thank you for your compliment @guardrex!

The PR looks good to me.

Copy link

@CoskunSunali CoskunSunali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@guardrex
Copy link
Collaborator Author

guardrex commented Mar 12, 2024

Thanks, @CoskunSunali.

@guardrex guardrex removed the request for review from MackinnonBuck March 13, 2024 18:11
@guardrex
Copy link
Collaborator Author

I opened #32054 to address the Static Files Middleware/endpoint routing situation.

For this, I'll go ahead. I faithfully convey Stephen's remarks.

@guardrex guardrex merged commit 388cf36 into main Mar 13, 2024
3 checks passed
@guardrex guardrex deleted the guardrex/blazor-fallback-auth branch March 13, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using fallback authorization policy breaks Blazor Server after migrating to .NET 8
2 participants