Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor RC2 Updates 8.0 #30576

Merged
merged 24 commits into from
Oct 10, 2023
Merged

Blazor RC2 Updates 8.0 #30576

merged 24 commits into from
Oct 10, 2023

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Oct 4, 2023

Addresses #28161
Fixes #30372
Addresses #30002

Notes

  • Still a bit draft-y-ish at the moment. The whole PR will be edited on Monday morning.
  • JS initializers coverage will be added on Monday. For RTM
  • Release Notes updates will be made on Monday.
  • The PR will merge and be taken live on Tuesday when RC2 releases.
  • Adds a new section to the Render Modes article for Steve's exposition on custom shorthand render modes. I thought that was 😎 Pretty Slick™ 😎.
  • UPDATE for HttpContext: I'll update and cross-link the passing tokens guidance on Monday. Done! 👍

The tracking issue has been updated ...

Blazor .NET 8 tracking issue
#28161


Internal previews

Toggle expand/collapse
📄 File 🔗 Preview link
aspnetcore/blazor/advanced-scenarios.md ASP.NET Core Blazor advanced scenarios (render tree construction)
aspnetcore/blazor/call-web-api.md Call a web API from an ASP.NET Core Blazor app
aspnetcore/blazor/components/index.md ASP.NET Core Razor components
aspnetcore/blazor/components/integration.md aspnetcore/blazor/components/integration
aspnetcore/blazor/components/js-spa-frameworks.md Use Razor components in JavaScript apps and SPA frameworks
aspnetcore/blazor/components/prerender.md Prerender ASP.NET Core Razor components
aspnetcore/blazor/components/quickgrid.md ASP.NET Core Blazor QuickGrid component
aspnetcore/blazor/components/render-modes.md aspnetcore/blazor/components/render-modes
aspnetcore/blazor/debug.md Debug ASP.NET Core apps
aspnetcore/blazor/file-downloads.md ASP.NET Core Blazor file downloads
aspnetcore/blazor/file-uploads.md ASP.NET Core Blazor file uploads
aspnetcore/blazor/forms-and-input-components.md ASP.NET Core Blazor forms and input components
aspnetcore/blazor/fundamentals/dependency-injection.md aspnetcore/blazor/fundamentals/dependency-injection
aspnetcore/blazor/fundamentals/handle-errors.md Handle errors in ASP.NET Core Blazor apps
aspnetcore/blazor/fundamentals/routing.md ASP.NET Core Blazor routing and navigation
aspnetcore/blazor/fundamentals/signalr.md ASP.NET Core Blazor SignalR guidance
aspnetcore/blazor/globalization-localization.md ASP.NET Core Blazor globalization and localization
aspnetcore/blazor/images.md aspnetcore/blazor/images
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md Call .NET methods from JavaScript functions in ASP.NET Core Blazor
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md Call JavaScript functions from .NET methods in ASP.NET Core Blazor
aspnetcore/blazor/javascript-interoperability/import-export-interop.md JavaScript [JSImport]/[JSExport] interop with ASP.NET Core Blazor
aspnetcore/blazor/performance.md aspnetcore/blazor/performance
aspnetcore/blazor/project-structure.md ASP.NET Core Blazor project structure
aspnetcore/blazor/security/index.md ASP.NET Core Blazor authentication and authorization
aspnetcore/blazor/security/server/additional-scenarios.md Server-side ASP.NET Core Blazor additional security scenarios
aspnetcore/blazor/security/server/index.md [Visual Studio](https://review.learn.microsoft.com/en-us/aspnet/core/blazor/security/server/index?branch=pr-en-us-30576)
aspnetcore/blazor/state-management.md aspnetcore/blazor/state-management
aspnetcore/blazor/tooling.md Tooling for ASP.NET Core Blazor
aspnetcore/blazor/tutorials/build-a-blazor-app.md Build a Blazor todo list app
aspnetcore/mvc/views/razor.md Razor syntax reference for ASP.NET Core

Note
This table shows preview links for the 30 files with the most changes. For preview links for other files in this PR, select OpenPublishing.Build Details within checks.

@guardrex guardrex self-assigned this Oct 4, 2023
@guardrex guardrex marked this pull request as ready for review October 6, 2023 13:53
@@ -1478,9 +1476,6 @@ In the preceding code, the CSS selector, `#app`, indicates that the `App` compon
<div id="app">...</app>
```

<!-- UPDATE 8.0 Need to check on this: Is this still valid in a
BW app, and is the render-mode still set in this way? -->

MVC and Razor Pages apps can also use the [Component Tag Helper](xref:Microsoft.AspNetCore.Mvc.TagHelpers.ComponentTagHelper) to register statically-rendered Blazor WebAssembly root components:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure why this specifically refers to using the component tag helper with statically rendered Blazor WebAssembly components. The component tag helper supports the interactive server and WebAssembly render modes. It doesn't support Auto.

Copy link
Collaborator Author

@guardrex guardrex Oct 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discuss this further. This whole section is specifically about rendering static root components. I thought it was correct in that context.

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have some comments, but this is all in the right direction.

@guardrex
Copy link
Collaborator Author

guardrex commented Oct 8, 2023

@danroth27 ... Reacted to feedback.

Sorry for so many commits to get your suggestions batched. GH was throwing an error but wouldn't tell me which suggestion was failing. I had to block them out in groups to narrow it down to the one that was choking.

I'm going to start the Release Notes update now but finish it on Monday morning. Will be on PR #30619, and I'll merge it Monday morning but circle around with cross-links for any new sections after RC2 releases.

I'll go back over this entire PR looking for further improvements and gremlins 😈 .

For some highlights .....................

Blazor identity UI

Added to Release Notes - Done! 👍; however, I probably need to discuss with Halter to confirm that I'm writing the articles for the security node to cover the new API.

Support for dialog cancel and close events

... moving to Release Notes. - Done! 👍

Statically-rendered root components

For ...

MVC and Razor Pages apps can also use the [Component Tag Helper](xref:Microsoft.AspNetCore.Mvc.TagHelpers.ComponentTagHelper) to register statically-rendered Blazor WebAssembly root components:

... that whole section is about statically-rendered root components, so I thought this remark in that context was correct.

automatic (Auto)

... going back to just Auto.

New section on custom shorthand render modes

... check again to see if the rewrite is correct. It's still might be rough, and you still might decide just to nix it. I liked it for a shorthand no-prerender approach, but it might not be worth it. As Steve said, how often will folks be disabling prerendering? Also, it's probably going to be more useful if more flags are added, but that might never happen.

Forms article

Moved the Enhanced navigation and form handling section to the bottom and dropped it from the example forms.

... AND ... WRT reorganizing the coverage ... I recommend doing it during RC2, not for this PR. However, I'll try to squeeze it in now if you want. Opened Reorganize Blazor forms coverage 8.0 #30618.

enhancedload event to listen for enhanced page updates

... moved to the Routing topic and cross-linked from the Forms topic.

Disabling SIMD

Holding coverage for .NET 9 ... I commented it out in place with a doc author comment.

@guardrex guardrex changed the title [HOLD] Blazor RC2 Updates 8.0 Blazor RC2 Updates 8.0 Oct 10, 2023
@guardrex guardrex merged commit c66455f into main Oct 10, 2023
@guardrex guardrex deleted the guardrex/blazor-rc2 branch October 10, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor APIs to preserve content between enhanced navigations 8.0
2 participants