-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update WASM AOT guidance 8.0 #30152
Update WASM AOT guidance 8.0 #30152
Conversation
aspnetcore/blazor/tooling.md
Outdated
:::moniker range=">= aspnetcore-7.0 < aspnetcore-8.0" | ||
```xml | ||
<PropertyGroup> | ||
<RunAOTCompilation>true</RunAOTCompilation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RunAOTCompilation
should not be necessary anymore, right @radekdoulik ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think RunAOTCompilation was necessary to use SIMD in Net7 as interpreter didn't use it at all. But that's not the case anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok ... I re-organized everything on the latest commit.
The AOT section duplicates the content for 6.0/7.0 and 8.0+ until we hear back from @radekdoulik. 👂
> | ||
> The `wasm-tools` workload installs the build tools for .NET 7 projects. However, the .NET 7 version of the build tools are incompatible with existing projects built with .NET 6. Projects using the build tools that must support both .NET 6 and .NET 7 must use multi-targeting. | ||
> | ||
> Use the `wasm-tools-net6` workload for .NET 6 projects when developing apps with the .NET 7 SDK. To install the `wasm-tools-net6` workload, execute the following command from an administrative command shell: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already wasm-tools-net7
and wasm-tools
is Net8 I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made an update for wasm-tools
to say it applies to the latest release, but I don't know what this should say for .NET 6 projects. You may need to supply the exact line of text that makes sense. The language here came directly from Dan's blog post IIRC.
You probably already figured out ..........
Damn it Jim! I'm a doc author, not a compiler expert!
— Dr. Leonard H. "Bones" McCoy (DeForest Kelley) Star Trek, ©1966-69 Paramount Pictures
🙈😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note in passing that the rest of the AOT content (and runtime relinking in a following section) is at ...
I think a long-range task is to combine the content from both docs into one new article in the Fundamentals node. I opened an issue to do the work at ...
Combine and relocate WASM build tools content
#30153
With the .NET 8 workload, which will go right into 24Q1, I won't reach that for a while tho 🏃.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I guess you could merge it and if Radek would have more comments about AOT it could be separate PR
I have the duplicated AOT content, so I'll remove that for now. @radekdoulik, I'm going to merge this after one more commit and go ahead and merge it to the live doc set. Could you look it over for the two versions to see if any changes are needed for either set of remarks ...
For the rest of what we maintain (over in the Host and Deploy node) on AOT, that's at ... ... and I plan to combine all of this into a standalone new article in the Fundamentals node next year. |
Fixes #30151
I'm glad you said something in spite of my working on it. This is looking much better.
Internal previews