Metrics /2 #29646
Metrics /2 #29646
Conversation
There was a problem hiding this comment.
@JamesNK what can I do to see ASP.NET Core metrics in the two places I commented the MD file? This is early draft, but can you review what I've got and how I'm starting?
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@JamesNK please suggest the correct terminology. Counters and metrics are used interchangeably. |
| * **Instrumentation:** Code in .NET libraries takes measurements and associates these measurements with a metric name. | ||
| * **Collection:** A .NET app configures named metrics to be transmitted from the app for external storage and analysis. Some tools may perform configuration outside the app using configuration files or a UI tool. | ||
|
|
||
| Instrumented code can record numeric measurements, but the measurements need to be aggregated, transmitted, and stored to create useful metrics for monitoring. The process of aggregating, transmitting, and storing data is called collection. This tutorial shows several examples of collecting metrics: |
There was a problem hiding this comment.
do we need to mention the dimensions/tags here?
@tarekgh can you suggest text for dimensions/tags or provide a link?
There was a problem hiding this comment.
You may add the sentence Measurements can also be associated with key-value pairs called tags that allow data to be categorized for analysis. and optionally add the link Multi-dimensional metrics.
Co-authored-by: James Newton-King <[email protected]>
There was a problem hiding this comment.
A few comments on some of the metrics content you all added a little while back. @JamesNK @Rick-Anderson
| * **Instrumentation:** Code in .NET libraries takes measurements and associates these measurements with a metric name. | ||
| * **Collection:** A .NET app configures named metrics to be transmitted from the app for external storage and analysis. Some tools may perform configuration outside the app using configuration files or a UI tool. | ||
|
|
||
| Instrumented code can record numeric measurements, but the measurements need to be aggregated, transmitted, and stored to create useful metrics for monitoring. The process of aggregating, transmitting, and storing data is called collection. This tutorial shows several examples of collecting metrics: |
There was a problem hiding this comment.
Instrumented code can record numeric measurements, but the measurements need to be aggregated, transmitted, and stored to create useful metrics for monitoring. The process of aggregating, transmitting, and storing data is called collection.
These two sentences feel duplicative with the two bullets right above. I think you could either keep the bullet list or keep these two sentences but having both seems unnecessary.
There was a problem hiding this comment.
I'll get this fixed in #30092
Fixes #29292
Internal previews