-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blazor Hybrid dev tools topic #25384
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Luke, this is a great start! I've left some clarifying comments below.
Would it be possible to add instructions for Windows/MacOS as well, they should just be an extension of the existing iOS instructions (for Mac) and CTRL+SHIFT+I (for Windows)
Co-authored-by: Tanay Parikh <[email protected]>
Co-authored-by: Tanay Parikh <[email protected]>
@TanayParikh Updates made. For the Safari image for macOS, I had to Photoshop your iOS image down to just the Web Inspector, which might be ok. The problem is that my personal Mac (that I own and have been using for the last several years) is now too old to run .NET. I can't get one from Aquent 😠. There's nothing that I can do about that. Dan and Artak are aware of the situation. Anyway ... if you want a macOS-specific Safari image (i.e., that shows the app running, too), you'd need to create the image for me and post it in an issue comment here. Also, I added a "doc pivot" (tab control) for the OSs. We usually do that for OS guidance. If you prefer that I split it back out into sections, that's fine ... I can do that. Let me know. 👂 |
Co-authored-by: Tanay Parikh <[email protected]>
Ok ... updates performed thus far. btw ... wrt ...
If you do produce an image for Safari with macOS ... It's not critical, but I recommend naming the test app "MauiBlazor" (with no space in there) to match the general Blazor Hybrid app naming that docs will adopt (the others are UPDATE (3/25): Changed the name on #25422 from |
@TanayParikh ... I commented-out the macOS piece for that pivot, tell the reader to use the iOS instructions, and link to reload the article to that pivot. For bug dotnet/maui#5561, it's tracked now on the Blazor Hybrid docs project to update this doc later after it's resolved. |
Co-authored-by: Tanay Parikh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great, lets ship it!
Does Dan want to see it first? |
@danroth27 ... Do you want to review/approve this before we merge? |
Co-authored-by: Tanay Parikh <[email protected]>
Closed and re-opened because it looked like the build was hung. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! My one piece of feedback is the title. When I was looking for this doc in the TOC I scanned for "browser developer tools" but I didn't see it. I thought "Handle errors" meant runtime error management.
I think @guardrex and I discussed this briefly at one point. Luke's concern was |
I suspect that using with browser dev tools will be an important enough part of the Blazor Hybrid dev workflow that it deserves its own standalone easily discoverable topic. Otherwise, we risk burying this info with a bunch of unrelated info. We can still have a separate Error handling topic if we want content related to runtime error management. |
I'm OOF on the road for a couple of hours, but I'll have it reverted back to the original topic title, URL, and UID by EOD. |
Fixes #25382
Addresses #24956
Internal Review Topic
Notes:
BlazorWebView
, and I'll change that if it makes more sense to useWebView
.🇺🇦