Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor Hybrid dev tools topic #25384

Merged
merged 17 commits into from
Mar 30, 2022
Merged

Blazor Hybrid dev tools topic #25384

merged 17 commits into from
Mar 30, 2022

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Mar 22, 2022

Fixes #25382
Addresses #24956

Internal Review Topic

Notes:

  • The PR currently uses BlazorWebView, and I'll change that if it makes more sense to use WebView.
  • Please confirm/update the UID (for cross-linking) and the filename (for the topic's URL). These are the most important aspects to get right for the future.

🇺🇦

@guardrex guardrex mentioned this pull request Mar 22, 2022
25 tasks
@guardrex guardrex self-assigned this Mar 22, 2022
@guardrex guardrex marked this pull request as ready for review March 23, 2022 13:15
Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luke, this is a great start! I've left some clarifying comments below.

Would it be possible to add instructions for Windows/MacOS as well, they should just be an extension of the existing iOS instructions (for Mac) and CTRL+SHIFT+I (for Windows)

aspnetcore/toc.yml Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/developer-tools.md Outdated Show resolved Hide resolved
@guardrex
Copy link
Collaborator Author

@TanayParikh Updates made.

For the Safari image for macOS, I had to Photoshop your iOS image down to just the Web Inspector, which might be ok. The problem is that my personal Mac (that I own and have been using for the last several years) is now too old to run .NET. I can't get one from Aquent 😠. There's nothing that I can do about that. Dan and Artak are aware of the situation. Anyway ... if you want a macOS-specific Safari image (i.e., that shows the app running, too), you'd need to create the image for me and post it in an issue comment here.

Also, I added a "doc pivot" (tab control) for the OSs. We usually do that for OS guidance. If you prefer that I split it back out into sections, that's fine ... I can do that. Let me know. 👂

aspnetcore/zone-pivot-groups.yml Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/handle-errors.md Outdated Show resolved Hide resolved
aspnetcore/blazor/hybrid/handle-errors.md Show resolved Hide resolved
aspnetcore/blazor/hybrid/handle-errors.md Outdated Show resolved Hide resolved
@guardrex
Copy link
Collaborator Author

guardrex commented Mar 24, 2022

Ok ... updates performed thus far.

btw ... wrt ...

you'd need to create the image for me and post it in an issue comment here.

If you do produce an image for Safari with macOS ...

It's not critical, but I recommend naming the test app "MauiBlazor" (with no space in there) to match the general Blazor Hybrid app naming that docs will adopt (the others are WinFormsBlazor and WpfBlazor). This is a change that I'll be making shortly to the tutorial for .NET MAUI. I have the images. I just haven't had a chance to swap them in yet ... maybe on Friday.

UPDATE (3/25): Changed the name on #25422 from MauiApp1 (VS default) to MauiBlazor to match the format of the other Hybrid tutorial app names.

@guardrex
Copy link
Collaborator Author

guardrex commented Mar 24, 2022

@TanayParikh ... I commented-out the macOS piece for that pivot, tell the reader to use the iOS instructions, and link to reload the article to that pivot.

For bug dotnet/maui#5561, it's tracked now on the Blazor Hybrid docs project to update this doc later after it's resolved.

Copy link
Contributor

@TanayParikh TanayParikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great, lets ship it!

@guardrex
Copy link
Collaborator Author

Does Dan want to see it first?

@guardrex
Copy link
Collaborator Author

@danroth27 ... Do you want to review/approve this before we merge?

@guardrex guardrex closed this Mar 25, 2022
@guardrex guardrex reopened this Mar 25, 2022
@guardrex
Copy link
Collaborator Author

Closed and re-opened because it looked like the build was hung.

@guardrex guardrex merged commit 389253c into main Mar 30, 2022
@guardrex guardrex deleted the guardrex/blazor-hybrid-dev-tools branch March 30, 2022 00:37
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! My one piece of feedback is the title. When I was looking for this doc in the TOC I scanned for "browser developer tools" but I didn't see it. I thought "Handle errors" meant runtime error management.

@TanayParikh
Copy link
Contributor

I scanned for "browser developer tools" but I didn't see it. I thought "Handle errors" meant runtime error management.

I think @guardrex and I discussed this briefly at one point. Luke's concern was browser developer tools would be too specific, and limit our ability to expand the section to cover other types of error handling & management in the future. @guardrex did I capture our discussion appropriately or did I miss something?

@danroth27
Copy link
Member

Luke's concern was browser developer tools would be too specific, and limit our ability to expand the section to cover other types of error handling & management in the future

I suspect that using with browser dev tools will be an important enough part of the Blazor Hybrid dev workflow that it deserves its own standalone easily discoverable topic. Otherwise, we risk burying this info with a bunch of unrelated info. We can still have a separate Error handling topic if we want content related to runtime error management.

@guardrex
Copy link
Collaborator Author

I'm OOF on the road for a couple of hours, but I'll have it reverted back to the original topic title, URL, and UID by EOD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor Hybrid 'Use browser dev tools'
3 participants