Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazor InputRadio/Group components #19555

Merged
merged 4 commits into from
Aug 24, 2020
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Aug 18, 2020

Fixes #19522

Internal Review Topic (links to Radio buttons section)

I'm not quite there locally for preview bits yet. I usually get on the new bits at RC1. This PR was derived from the engineering PR.

  • InputRadio and InputRadioGroup component coverage.
  • Standardizing the use of @ on submit methods.

Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Do you think we still need this section: https://github.com/dotnet/AspNetCore.Docs/pull/19555/files#diff-daa7e01c3897b91132b91d1ec06e7018R809, given there's now a first-party InputRadio solution? If you think we should leave it in for those using an older version of the framework, that sounds fine to me, just thought I'd check 😃

@guardrex
Copy link
Collaborator Author

@MackinnonBuck ... Yes, DR and Artak have advised in similar scenarios on other 5.0 PRs to keep the <5.0 approaches for the 3.x versions of the topics.

@guardrex
Copy link
Collaborator Author

@MackinnonBuck I think we can simplify manufacturer text that goes with the InputRadio components from ...

@foreach (var manufacturer in (Manufacturer[])Enum
    .GetValues(typeof(Manufacturer)))
{
    <InputRadio Value="manufacturer" />
    @manufacturer.ToString();
    <br>
}

... to ...

@foreach (var manufacturer in (Manufacturer[])Enum
    .GetValues(typeof(Manufacturer)))
{
    <InputRadio Value="manufacturer" />
    @manufacturer
    <br>
}

I put that update on the last commit. Seem ok to you?

@MackinnonBuck
Copy link
Member

@guardrex Yep, looks good!

@guardrex guardrex merged commit 048255b into master Aug 24, 2020
@guardrex guardrex deleted the guardrex/blazor-inputradio branch August 24, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor InputRadio component
2 participants