Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修复在当前 LocalizationValues 无法取值时，从 fallback 取值失败的问题。 #7

Merged
merged 1 commit into from
Oct 30, 2024
Merged

修复在当前 LocalizationValues 无法取值时，从 fallback 取值失败的问题。 #7

merged 1 commit into from
Oct 30, 2024

Conversation

JasonGrass
Copy link
Contributor

发现这里的代码跑不起来 ： kkwpsv/WindowDebugger#5

@lindexi lindexi requested a review from walterlv October 30, 2024 11:25
walterlv
walterlv approved these changes Oct 30, 2024
View reviewed changes
src/dotnetCampus.Localizations.Analyzer/Assets/Templates/LocalizationValues.g.cs
{
return fallback[key];
}
return "";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这么长的语句，可以用更长的 null 传播表达式？

@walterlv walterlv merged commit 40f68a9 into main Oct 30, 2024
2 checks passed
@walterlv walterlv deleted the t/ljj/fix-get-value-from-fallback branch October 30, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterlv walterlv walterlv approved these changes

Assignees

@walterlv walterlv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGrass @walterlv