Fixed #1518 bug

[anjoy8]

Update CatalogContextModelSnapshot.cs

[sughosneo]

Hi @anjoy8 , thank you for submitting this PR. Will test and update.

[sughosneo]

Hi @anjoy8 , thank you for submitting this PR. Will test and update.

Hi @anjoy8, I did a quick test and I could see that it didn't update the Catalog table. Could you please test and debug it at your end ? You can follow below steps to reproduce the behavior :

To clean up :

docker stop $(docker ps -aq)
docker rm $(docker ps -aq)
docker volume rm $(docker volume ls -q)

!Note : Above commands will clean up all your docker setup. It's expected to run it only on dev environment.

And to run :

docker-compose up sqldata
docker-compose up

I will review the code in details.

Thank you.

[anjoy8]

Sorry, I'm fine here, but I'm not using Docker-compose,
normal debugging and running.

[sughosneo]

Hi @anjoy8, thanks for the update.

You should be able to reproduce the issue by the following steps :

• Perform clean up (mentioned above)
• Set the docker-compose project as a startup project in your Visual Studio environment.
• Then press F5 to run the solution.
• You can place a break point CatalogItem CreateCatalogItem method to debug.
• Or once all the containers are up and running you would notice that though [CatalogBrand] and [CatalogType] tables are populated but [dbo].[Catalog] table is still empty.

The reason it's not populating CatalogItem because it's throwing exceptions for line 203 in class CatalogContextSeed which actually gets originated from line PictureUri = column[Array.IndexOf(headers, "pictureuri")].Trim('"').Trim() within the CreateCatalogItem() method. That needs to be updated to incorporate PictureFileName. For e.g :PictureFileName = column[Array.IndexOf(headers, "picturefilename")].Trim('"').Trim()

!Note if you are connecting to a different SQL data source than docker you may have to drop the database Microsoft.eShopOnContainers.Services.CatalogDb to let it get populated again.

Now when you select Catalog.API as a startup project and run that (let's say after brining up only the sql container by using docker-compose up sqldata), then you would notice the control doesn't go to the GetCatalogItemsFromFile() method. Actually the data gets populated from the GetPreconfiguredItems() method. That's the reason in your local you see everything is populated.

You may want to fix this entire flow. And once you make the necessary changes you can test out the following scenarios just to double confirm everything is working fine.

• Visual Studio F5
• docker-compose up
• local k8s

Hope this helps !

[anjoy8]

Hi @sughosneo , thanks for your suggestion and reply!
After my debug, I found that there was something wrong with the CSV data,
and I submitted a PR(ad8ec3f). You can test it again.
If there is a problem, Please let me know the error message.
I will change it.

[sughosneo]

Hi @sughosneo , thanks for your suggestion and reply!
After my debug, I found that there was something wrong with the CSV data,
and I submitted a PR(ad8ec3f). You can test it again.
If there is a problem, Please let me know the error message.
I will change it.

Thanks for the update @anjoy8 . I have left a quick review comment.
Also, wouldn't this be just be considered as name Roslyn Red T-Shirt" with " character ?

Does it work with docker-compose scenario as well ?

[anjoy8]

Hi @sughosneo , thanks for your suggestion and reply!
After my debug, I found that there was something wrong with the CSV data,
and I submitted a PR(ad8ec3f). You can test it again.
If there is a problem, Please let me know the error message.
I will change it.

Thanks for the update @anjoy8 . I have left a quick review comment.
Also, wouldn't this be just be considered as name Roslyn Red T-Shirt" with " character ?

Does it work with docker-compose scenario as well ?

But here Split is " character , so it will truncate the data,

.Select(row => Regex.Split(row, ",(?=(?:[^\"]*\"[^\"]*\")*[^\"]*$)") )

An exception occurs:

Although this does not affect the operation of the project.

---

Also, sorry, I didn't use the Docker-compose test, if It still report an error.
You can modify it on your machine according to my modification ideas. I can turn off this PR.

[sughosneo]

Hi @sughosneo , thanks for your suggestion and reply!
After my debug, I found that there was something wrong with the CSV data,
and I submitted a PR(ad8ec3f). You can test it again.
If there is a problem, Please let me know the error message.
I will change it.

Thanks for the update @anjoy8 . I have left a quick review comment.
Also, wouldn't this be just be considered as name Roslyn Red T-Shirt" with " character ?
Does it work with docker-compose scenario as well ?

But here Split is " character , so it will truncate the data,

.Select(row => Regex.Split(row, ",(?=(?:[^\"]*\"[^\"]*\")*[^\"]*$)") )

An exception occurs:

Although this does not affect the operation of the project.

Also, sorry, I didn't use the Docker-compose test, if It still report an error.
You can modify it on your machine according to my modification ideas. I can turn off this PR.

Thanks @anjoy8 . Will test and update.

[sughosneo]

I have tested this PR with docker-compose and local-k8s scenario. It works fine. So merging the changes.

Thanks @anjoy8