Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple job values in pods view #76

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

dotdc
Copy link
Owner

@dotdc dotdc commented Dec 15, 2023

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • Added the ability to filter using the job label to fix some queries in k8s-views-pods.json for users that have multiple values in the job label.

Optional Fields

✔️ Which issue(s) this PR fixes?

@nlamirault
Copy link

i change the variable to this:

{
        "current": {
          "selected": false,
          "text": "kube-state-metrics",
          "value": "kube-state-metrics"
        },
        "datasource": {
          "type": "prometheus",
          "uid": "${datasource}"
        },
        "definition": "label_values(kube_pod_info,job)",
        "hide": 0,
        "includeAll": false,
        "multi": true,
        "name": "job",
        "options": [],
        "query": {
          "qryType": 1,
          "query": "label_values(kube_pod_info,job)",
          "refId": "PrometheusVariableQueryEditor-VariableQuery"
        },
        "refresh": 1,
        "regex": "",
        "skipUrlSync": false,
        "sort": 1,
        "type": "query"
      }

and it works fine. Values comes from metrics set by kube-state-metrics

@dotdc dotdc merged commit b25aca7 into master Dec 15, 2023
1 check passed
@dotdc dotdc deleted the fix/multiple-job-values-in-pods-view branch December 15, 2023 17:17
@dotdc
Copy link
Owner Author

dotdc commented Dec 15, 2023

Done, thanks!

@dotdc
Copy link
Owner Author

dotdc commented Apr 25, 2024

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Pod memory / cpu requests and limits invalid values with Opencost installed
2 participants