Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: using empty image label for container metrics (#122)" #126

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

buroa
Copy link
Contributor

@buroa buroa commented Oct 3, 2024

This reverts commit 6a5ef77.

Pull Request

Required Fields

🔎 What kind of change is it?

  • fix

🎯 What has been changed and why do we need it?

  • Previous PR broke setups

Optional Fields

✔️ Which issue(s) this PR fixes?

💬 Additional information?

  • We need to figure out a better way

@buroa buroa requested a review from dotdc as a code owner October 3, 2024 12:56
dashboards/k8s-views-pods.json Outdated Show resolved Hide resolved
dashboards/k8s-views-nodes.json Outdated Show resolved Hide resolved
dashboards/k8s-views-namespaces.json Outdated Show resolved Hide resolved
dashboards/k8s-views-global.json Outdated Show resolved Hide resolved
dashboards/k8s-addons-prometheus.json Outdated Show resolved Hide resolved
@dotdc dotdc merged commit e2ea063 into dotdc:master Oct 3, 2024
1 check passed
@dotdc
Copy link
Owner

dotdc commented Oct 3, 2024

🎉 This PR is included in version 2.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants