-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert default ID scalar input type to string #9497
Conversation
🦋 Changeset detectedLatest commit: 460ece4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@graphql-codegen/visitor-plugin-common |
4.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
4.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
4.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
5.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
4.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
4.0.1-alpha-20230613103340-460ece4ec |
npm ↗︎ unpkg ↗︎ |
.changeset/empty-grapes-care.md
Outdated
@@ -3,7 +3,6 @@ | |||
'@graphql-codegen/typescript-operations': patch | |||
'@graphql-codegen/typescript': patch | |||
'@graphql-codegen/typescript-resolvers': patch | |||
'@graphql-codegen/cli': patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the CLI package needs to be bumped in this case because only the test was changed and it didn't have @graphql-codegen/visitor-plugin-common
or @graphql-codegen/cli
in its dep list
💻 Website PreviewThe latest changes are available as preview in: https://cbf8335d.graphql-code-generator.pages.dev |
Description
We changed the ID Scalar input type to
string | number
fromstring
in the latest major version oftypescript
. This causes issues for server plugins (e.g.typescript-resolvers
) because the scalar type needs to be manually inverted on setup which is confusing.This PR reverts ID scalar input back to
string
to ensuretypescript
plugin works for all client/server plugins that depend on it.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: