-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/improved before one file write hook #8662
Features/improved before one file write hook #8662
Conversation
🦋 Changeset detectedLatest commit: 0311fc0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
69c94d9
to
2408288
Compare
2408288
to
22e9ab6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wondering if there is something we can do to have tests for this 🤔
did you see the new test inside |
22e9ab6
to
0311fc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I missed that. Amazing work!
Description
Allow to modify content from
beforeOneFileWrite
for faster and more efficient post modifications.See entire discussion in #8643.
This PR should not be merged before #8652 and #8661 as this PR builds ontop of a refactoring introduced in those PRs.Update: #8652 and #8661 have been merged.
Related #8643
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Test Environment:
Checklist: