-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: top level ts-node registration bug #8590
Conversation
🦋 Changeset detectedLatest commit: 47282af The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Diizzayy, I've updated the changeset to minor since we use minor for breaking changes and major for big releases.
Besides that, I conducted some manual QA and did not found any regression, testing with the following config:
import { CodegenConfig } from "@graphql-codegen/cli";
import dotenv from "dotenv";
import { schemaPath } from "./test";
dotenv.config();
const config: CodegenConfig = {
schema: schemaPath,
documents: [process.env.DOCS!],
generates: {
"types.ts": {
plugins: ["typescript", "typescript-operations"],
},
},
};
export default config;
Looks good to me, thanks! ⚡
@charlypoly Happy to hear! Thanks again for taking the time to have another look into this |
Description
This PR simply averts from using a top level variable for the
TypeScriptLoader
to prevent the unnecessary early registration ofts-node
Related #8588
Type of change