Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(flow): flow-operations tries to spread inexact objects #8000 #8299

Closed
wants to merge 1 commit into from
Closed

feat(flow): flow-operations tries to spread inexact objects #8000 #8299

wants to merge 1 commit into from

Conversation

Athelian
Copy link

@Athelian Athelian commented Aug 30, 2022 •
edited
Loading

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Flow-operations tries to spread exact/inexact objects into the same merged object which leads to flow errrors.

Related dotansimha/graphql-code-generator-community#198 (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

https://flow.org/try/#0FAFwngDgpgBAJABQJYGMDWAeA8gJyQcyQDsAuGLAIwCsoUQAaGAaSjAGczKa6A+GAXnhcAsgEMISDC3aMprHgAo0ZaQEoBfOAFEANlAC2UIiAAqkKNjyEijaTx4BuYKHMwcUAGZR3RFLEEA3gA+ogD8ZBQA9pF6okRBAL7O4NAwHjqRAO5Y0DiiIEiRRGxmqYHAMDAAdDUBMAD69SlGooZkAOQASp7eRn7tMAn0FdU1iKiY7l4+fowjwTBhZABUMIk8wEnAKEVsIDAgUHtk6Vk53vmFxaX+MAGNzUStUGQARN3TfVCvjKJkIDgAK5QBJAA

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Environment:

  • OS: Linux
  • Flow: 0.181.2
  • @graphql-codegen/flow-operations version: ^2.2.13

Checklist:

  • I have followed the CONTRIBUTING doc and the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2022

⚠️ No Changeset found

Latest commit: 6513cc2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 30, 2022

@Athelian is attempting to deploy a commit to the The Guild Team on Vercel.

A member of the Team first needs to authorize it.

@Athelian Athelian mentioned this pull request Aug 30, 2022
Closed
@charlypoly
Copy link
Contributor

charlypoly commented Nov 7, 2022 •
edited
Loading

Hi!

All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.

Community plugins:
  • @graphql-codegen/typescript-react-apollo
  • @graphql-codegen/typescript-graphql-request
  • @graphql-codegen/typescript-apollo-angular
  • @graphql-codegen/typescript-apollo-client-helpers
  • @graphql-codegen/typescript-react-query
  • @graphql-codegen/typescript-urql
  • @graphql-codegen/named-operations-object
  • @graphql-codegen/urql-introspection
  • @graphql-codegen/flow-resolvers
  • @graphql-codegen/typescript-vue-apollo
  • @graphql-codegen/typescript-rtk-query
  • @graphql-codegen/flow-operations
  • @graphql-codegen/typescript-msw
  • @graphql-codegen/typescript-mongodb
  • @graphql-codegen/typescript-type-graphql
  • @graphql-codegen/jsdoc
  • @graphql-codegen/typescript-vue-urql
  • @graphql-codegen/kotlin
  • @graphql-codegen/typescript-vue-apollo-smart-ops
  • @graphql-codegen/java
  • @graphql-codegen/c-sharp-operations
  • @graphql-codegen/hasura-allow-list
  • @graphql-codegen/typescript-stencil-apollo
  • @graphql-codegen/relay-operation-optimizer
  • @graphql-codegen/typescript-oclif
  • @graphql-codegen/java-resolvers
  • @graphql-codegen/java-apollo-android
  • @graphql-codegen/flutter-freezed

Please move your PR by following these steps:

From your current PR branch:

Open the PR on dotansimha/graphql-code-generator-community and close this PR.

Thank you!

@Athelian
Copy link
Author

Athelian commented Nov 7, 2022

Hi!

All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.

Community plugins:

Please move your PR by following these steps:

From your current PR branch:

  • git remote add codegen-community [email protected]:dotansimha/graphql-code-generator-community.git
  • git fetch codegen-community
  • git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.

Thank you!

Thank you, but I got permission denied with these steps:

ath@ath-aurora:~/graphql-code-generator$ git remote add codegen-community [email protected]:dotansimha/graphql-code-generator-community.git
ath@ath-aurora:~/graphql-code-generator$ git fetch codegen-community

remote: Enumerating objects: 765, done.
remote: Counting objects: 100% (506/506), done.
remote: Compressing objects: 100% (136/136), done.
remote: Total 765 (delta 362), reused 506 (delta 362), pack-reused 259
Receiving objects: 100% (765/765), 421.43 KiB | 592.00 KiB/s, done.
Resolving deltas: 100% (465/465), completed with 57 local objects.
From github.com:dotansimha/graphql-code-generator-community
 * [new branch]          community                  -> codegen-community/community
 * [new branch]          main                       -> codegen-community/main
 * [new branch]          renovate/auto-bind-5.x     -> codegen-community/renovate/auto-bind-5.x
 * [new branch]          renovate/babel-monorepo    -> codegen-community/renovate/babel-monorepo
 * [new branch]          renovate/change-case-all-1.x -> codegen-community/renovate/change-case-all-1.x
 * [new branch]          renovate/changesets-changelog-github-0.x -> codegen-community/renovate/changesets-changelog-github-0.x
 * [new branch]          renovate/lodash-4.x        -> codegen-community/renovate/lodash-4.x
 * [new branch]          renovate/major-graphql-tools-monorepo -> codegen-community/renovate/major-graphql-tools-monorepo
 * [new branch]          renovate/node-18.x         -> codegen-community/renovate/node-18.x
 * [new branch]          renovate/oclif-command-1.x -> codegen-community/renovate/oclif-command-1.x
 * [new branch]          renovate/reduxjs-toolkit-1.x -> codegen-community/renovate/reduxjs-toolkit-1.x
 * [new branch]          renovate/urql-introspection-1.x -> codegen-community/renovate/urql-introspection-1.x
ath@ath-aurora:~/graphql-code-generator$ 
ath@ath-aurora:~/graphql-code-generator$ git push codegen-community

ERROR: Permission to dotansimha/graphql-code-generator-community.git denied to Athelian.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

@charlypoly
Copy link
Contributor

Hi!
All community plugins (see list below) have been moved to a new dotansimha/graphql-code-generator-community.
Community plugins:

Please move your PR by following these steps:

From your current PR branch:

  • git remote add codegen-community [email protected]:dotansimha/graphql-code-generator-community.git
  • git fetch codegen-community
  • git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community and close this PR.
Thank you!

Thank you, but I got permission denied with these steps:

ath@ath-aurora:~/graphql-code-generator$ git remote add codegen-community [email protected]:dotansimha/graphql-code-generator-community.git
ath@ath-aurora:~/graphql-code-generator$ git fetch codegen-community

remote: Enumerating objects: 765, done.
remote: Counting objects: 100% (506/506), done.
remote: Compressing objects: 100% (136/136), done.
remote: Total 765 (delta 362), reused 506 (delta 362), pack-reused 259
Receiving objects: 100% (765/765), 421.43 KiB | 592.00 KiB/s, done.
Resolving deltas: 100% (465/465), completed with 57 local objects.
From github.com:dotansimha/graphql-code-generator-community
 * [new branch]          community                  -> codegen-community/community
 * [new branch]          main                       -> codegen-community/main
 * [new branch]          renovate/auto-bind-5.x     -> codegen-community/renovate/auto-bind-5.x
 * [new branch]          renovate/babel-monorepo    -> codegen-community/renovate/babel-monorepo
 * [new branch]          renovate/change-case-all-1.x -> codegen-community/renovate/change-case-all-1.x
 * [new branch]          renovate/changesets-changelog-github-0.x -> codegen-community/renovate/changesets-changelog-github-0.x
 * [new branch]          renovate/lodash-4.x        -> codegen-community/renovate/lodash-4.x
 * [new branch]          renovate/major-graphql-tools-monorepo -> codegen-community/renovate/major-graphql-tools-monorepo
 * [new branch]          renovate/node-18.x         -> codegen-community/renovate/node-18.x
 * [new branch]          renovate/oclif-command-1.x -> codegen-community/renovate/oclif-command-1.x
 * [new branch]          renovate/reduxjs-toolkit-1.x -> codegen-community/renovate/reduxjs-toolkit-1.x
 * [new branch]          renovate/urql-introspection-1.x -> codegen-community/renovate/urql-introspection-1.x
ath@ath-aurora:~/graphql-code-generator$ 
ath@ath-aurora:~/graphql-code-generator$ git push codegen-community

ERROR: Permission to dotansimha/graphql-code-generator-community.git denied to Athelian.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Hi,

yes sorry, you need to fork the new repo, I've updated the instructions above.

@saihaj
Copy link
Collaborator

saihaj commented Oct 19, 2023 •
edited
Loading

Hey! this plugins has moved to our community repo https://github.com/dotansimha/graphql-code-generator-community/tree/main/packages/plugins/flow/operations

Please move your PR by following these steps:

From your current PR branch:

  • git remote add codegen-community [email protected]:dotansimha/graphql-code-generator-community.git
  • git fetch codegen-community
  • git push codegen-community

Open the PR on dotansimha/graphql-code-generator-community.

Thank you!

@saihaj saihaj closed this Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Athelian @charlypoly @saihaj