Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for @skip and @include directives in typescript-operations #5017

Merged
merged 31 commits into from
Nov 16, 2020

Conversation

gilgardosh
Copy link
Collaborator

@gilgardosh gilgardosh commented Nov 2, 2020

Related: #3836

TODO:

  • Reproduce with a failing test
  • Apply a fix in PreResolveTypes processor
  • Apply a fix in default Flow processor + tests for flow-operations
  • Add a changeset
  • Apply a fix in default TS processor (Pick)
  • Make sure it works with presets as well (because of the need for a new TS helper to solve that issue with Pick)

@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2020

🦋 Changeset detected

Latest commit: 981b6d6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-codegen/flow-operations Patch
@graphql-codegen/typescript-operations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dotansimha
Copy link
Owner

@gilgardosh please also note this one: #5002 , this is also a valid use case of @skip and @include and we might need to address that.

@dotansimha dotansimha closed this Nov 4, 2020
@dotansimha dotansimha reopened this Nov 4, 2020
@dotansimha dotansimha self-requested a review November 16, 2020 17:23
@dotansimha dotansimha merged commit 475aa9b into dotansimha:master Nov 16, 2020
hwillson added a commit to hwillson/graphql-code-generator that referenced this pull request Jan 3, 2023
This commit takes a first pass at introducing `@defer` typescript codegen
support. It follows a similar approach as the `@skip` / `@include`
functionality introduced in dotansimha#5017.

Related issue: dotansimha#7885
hwillson added a commit to hwillson/graphql-code-generator that referenced this pull request Jan 9, 2023
This commit takes a first pass at introducing `@defer` typescript codegen
support. It follows a similar approach as the `@skip` / `@include`
functionality introduced in dotansimha#5017.

Related issue: dotansimha#7885
hwillson added a commit to hwillson/graphql-code-generator that referenced this pull request Jan 9, 2023
This commit takes a first pass at introducing `@defer` typescript codegen
support. It follows a similar approach as the `@skip` / `@include`
functionality introduced in dotansimha#5017.

Related issue: dotansimha#7885
hwillson added a commit to hwillson/graphql-code-generator that referenced this pull request Jan 22, 2023
This commit takes a first pass at introducing `@defer` typescript codegen
support. It follows a similar approach as the `@skip` / `@include`
functionality introduced in dotansimha#5017.

Related issue: dotansimha#7885
hwillson added a commit to hwillson/graphql-code-generator that referenced this pull request Jan 22, 2023
This commit takes a first pass at introducing `@defer` typescript codegen
support. It follows a similar approach as the `@skip` / `@include`
functionality introduced in dotansimha#5017.

Related issue: dotansimha#7885
hwillson added a commit to hwillson/graphql-code-generator that referenced this pull request Jan 24, 2023
This commit takes a first pass at introducing `@defer` typescript codegen
support. It follows a similar approach as the `@skip` / `@include`
functionality introduced in dotansimha#5017.

Related issue: dotansimha#7885
beerose pushed a commit that referenced this pull request Mar 17, 2023
This commit takes a first pass at introducing `@defer` typescript codegen
support. It follows a similar approach as the `@skip` / `@include`
functionality introduced in #5017.

Related issue: #7885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants