-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/c sharp operations member name casing #816
Fix/c sharp operations member name casing #816
Conversation
…he naming convention
🦋 Changeset detectedLatest commit: c096c63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@saihaj what do you think about it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
How's the release schedule of the community plugins? |
have some CI issues blocking it will try toi get it fixed this week |
Description
Added support for the new configuration option
memberNameConvention
to the c-sharp-operations plugin. Now both C# plugins can generate C# code with standard member casing.The default is still camel case, to avoid generating code that breaks user's existing code base.
Related #798
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The existing tests of the
c-sharp-operations
plugin were extended with a new group of tests calledMemberNamingConfig
. Those tests cover non-defaultmemberNameConvention
values, currently only pascal case.Test Environment:
@graphql-codegen/c-sharp-operations
: 3.0.0Checklist:
CONTRIBUTING doc and the
style guidelines of this project