Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/c sharp operations member name casing #816

Merged

Conversation

mariusmuntean
Copy link
Contributor

Description

Added support for the new configuration option memberNameConvention to the c-sharp-operations plugin. Now both C# plugins can generate C# code with standard member casing.
The default is still camel case, to avoid generating code that breaks user's existing code base.

Related #798

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

The existing tests of the c-sharp-operations plugin were extended with a new group of tests called MemberNamingConfig. Those tests cover non-default memberNameConvention values, currently only pascal case.

Test Environment:

  • OS: macOS
  • @graphql-codegen/c-sharp-operations: 3.0.0
  • NodeJS: v16.13.2

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: c096c63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-codegen/c-sharp-operations Minor
@graphql-codegen/c-sharp-common Minor
@graphql-codegen/c-sharp Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mariusmuntean mariusmuntean mentioned this pull request Aug 8, 2024
18 tasks
@mariusmuntean mariusmuntean marked this pull request as ready for review August 9, 2024 07:24
@mariusmuntean
Copy link
Contributor Author

@saihaj what do you think about it?

Copy link
Collaborator

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@saihaj saihaj merged commit b1ec118 into dotansimha:main Aug 9, 2024
14 checks passed
@mariusmuntean
Copy link
Contributor Author

How's the release schedule of the community plugins?

@saihaj
Copy link
Collaborator

saihaj commented Aug 12, 2024

have some CI issues blocking it will try toi get it fixed this week

@github-actions github-actions bot mentioned this pull request Sep 5, 2024
@saihaj
Copy link
Collaborator

saihaj commented Sep 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants