fix(typescript-react-apollo): loosen defaultBaseOptions type #464
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TypeScript React Apollo's
defaultBaseOptions
object values are currently restricted tostring
:graphql-code-generator-community/packages/plugins/typescript/react-apollo/src/config.ts
Line 245 in 0fea1a8
but they can be any number of data types, i.e.
ignoreResults
is aboolean
.This loosens the type from
string
➡️any
.Related #463
Type of change
How Has This Been Tested?
configure an option with a non-string data type, i.e.
ignoreResults
:see that this passes TypeScript compilation
Checklist:
CONTRIBUTING doc and the
style guidelines of this project