feat(flow): flow-operations tries to spread inexact objects #8000

[Athelian]

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Flow-operations tries to spread exact/inexact objects into the same merged object which leads to flow errrors.
I have already been running with this change in a custom plugin for quite some time.

Related issue #8000

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Flow Try demonstrating the issue

How Has This Been Tested?

Pre-existing test demonstrates difference between useFlowExactObjects=false/true

Test Environment:

• OS: Linux
• Flow: 0.181.2
• @graphql-codegen/flow-operations version: ^2.2.13

Checklist:

• I have followed the CONTRIBUTING doc and the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Further comments

Forked from legacy repo

[charlypoly]

Hi @Athelian,

Thank you for your contribution! ⚡

Could you check the following:

• fix ESLint issues (see PR files)
• Locally run yarn generate:examples and commit the diff (to fix the dev-tests)

Thank you!

[Athelian]

Locally run yarn generate:examples and commit the diff (to fix the dev-tests)

Hi @charlypoly.

I think yarn generate:examples is failing on main, would you need extra hands on it?

And please lmk if you would prefer I rebase this PR instead of merge.

Thank you.

[saihaj]

Hey @Athelian can you please rebase this PR and hopefully that should make all tests pass then we can merge

[changeset-bot]

🦋 Changeset detected

Latest commit: f522b78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphql-codegen/flow-operations	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Athelian]

Hey @Athelian can you please rebase this PR and hopefully that should make all tests pass then we can merge

Done!

[saihaj]

hey @Athelian can you please add a test for this change and also run yarn changeset and create a patch which helps with release. You can learn here about changeset

[Athelian]

hey @Athelian can you please add a test for this change and also run yarn changeset and create a patch which helps with release. You can learn here about changeset

Hi @saihaj I added the changeset.

As for a new test, I am not sure if it is necessary: All pre-existing tests needed updating, and all differences between true/false can covered by Should respect flow option useFlowExactObjects=false

[saihaj]

CI is still failing @Athelian

[Athelian]

CI is still failing @Athelian

Failing CI looks working to me now if replicate in local.

Sorry for trouble.

[saihaj]

thank you for fixing!

[saihaj]

@graphql-codegen/[email protected]