Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FTM): New Toolbar - Implement Preview Button and Preview Toolbar #30854

Conversation

rjvelazco
Copy link
Contributor

@rjvelazco rjvelazco commented Dec 4, 2024

This pull request includes several updates to the DotEmaShellComponent and DotUveToolbarComponent to improve their functionality and styling. The most important changes include modifying location handling methods, updating button styles, and restructuring the toolbar component.

Changes to DotEmaShellComponent:

  • Replaced replaceState with go in the #updateLocation method to improve URL handling.
  • Updated test cases to use location.go instead of location.replaceState for consistency. [1] [2] [3]

Changes to DotUveToolbarComponent:

  • Added new styles for the toolbar and its components, including buttons and chips, to enhance the user interface.
  • Refactored the toolbar component template to include separate templates for edit and preview modes and added new buttons and functionality for better user experience. [1]R1, [2]
  • Updated test cases to reflect the new structure and functionality of the toolbar component, ensuring proper testing of the new features. [1] [2] [3] [4] [5]

Other Changes:

  • Added a new severity style for text buttons in _splitbutton.scss to standardize button appearance.
  • Updated button styles in dot-ema-bookmarks.component.html to include a smaller size class for better visual consistency.

Video

issue-30739-ftm-new-toolbar-implement-preview-button-and-preview-toolbar.mov

This PR fixes: #30739

@rjvelazco rjvelazco linked an issue Dec 5, 2024 that may be closed by this pull request
@rjvelazco rjvelazco marked this pull request as ready for review December 6, 2024 15:31
@rjvelazco rjvelazco requested review from zJaaal, KevinDavilaDotCMS, fmontes, oidacra, nicobytes and hmoreras and removed request for zJaaal December 6, 2024 18:17
@KevinDavilaDotCMS KevinDavilaDotCMS added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit 4aaeb73 Dec 6, 2024
22 checks passed
@KevinDavilaDotCMS KevinDavilaDotCMS deleted the issue-30739-ftm-new-toolbar-implement-preview-button-and-preview-toolbar branch December 6, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTM: New Toolbar - Implement Preview Button and Preview Toolbar
3 participants