Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(release) fix ci friendly revisions wrong property for revision #28500

Merged
merged 1 commit into from
May 9, 2024
Merged

ci(release) fix ci friendly revisions wrong property for revision #28500

merged 1 commit into from
May 9, 2024

Conversation

spbolton
Copy link
Contributor

@spbolton spbolton commented May 9, 2024

Proposed Changes

  • Property "release" was being set in .mvn/maven.config instead of "revision" in release branch causing revision to be fixed at the default 1.0.0

Test

  • Make sure that maven build shows correct version number for modules and not just "1.0.0"
  • Pulling release branch and building without any properties should build with the correct release number.
  • Check .mvn/maven.config has revision set correctly the blow is an example, changelist should be set to empty string to override the default of "-SNAPSHOT"
-Dprod=true
-Drevision=24.05.08
-Dchangelist=

@spbolton spbolton requested a review from a team as a code owner May 9, 2024 12:53
@spbolton spbolton enabled auto-merge May 9, 2024 12:54
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@spbolton spbolton added this pull request to the merge queue May 9, 2024
Merged via the queue into master with commit c3f6242 May 9, 2024
14 checks passed
@spbolton spbolton deleted the ci-friendly-versions branch May 9, 2024 14:45
@spbolton
Copy link
Contributor Author

Related to #28430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcolina dcolina dcolina approved these changes

@nollymar nollymar nollymar approved these changes

@jgambarios jgambarios jgambarios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spbolton @jgambarios @nollymar @dcolina