Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edit-page-2): Fixed layout tooltip and contentlet tools space #28202

Merged
merged 3 commits into from
Apr 16, 2024
Merged

fix(edit-page-2): Fixed layout tooltip and contentlet tools space #28202

merged 3 commits into from
Apr 16, 2024

Conversation

KevinDavilaDotCMS
Copy link
Contributor

@KevinDavilaDotCMS KevinDavilaDotCMS commented Apr 11, 2024 •
edited
Loading

Proposed Changes

  • "Advanced template" tooltip is only show when the layout is advanced
Screen.Recording.2024-04-10.at.18.57.06.mov
  • Fixed space on contenlet tools in new edit page
Screen.Recording.2024-04-10.at.18.57.45.mov

@KevinDavilaDotCMS KevinDavilaDotCMS changed the title Fixed both frontend issues feat(edit-page-2): Fixed layout tooltip and contentlet tools space Apr 11, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS changed the title feat(edit-page-2): Fixed layout tooltip and contentlet tools space fix(edit-page-2): Fixed layout tooltip and contentlet tools space Apr 11, 2024
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@KevinDavilaDotCMS KevinDavilaDotCMS added this pull request to the merge queue Apr 16, 2024
@KevinDavilaDotCMS KevinDavilaDotCMS linked an issue Apr 16, 2024 that may be closed by this pull request
Edit Page V2: Edit Contentlet Button Spacing Issue #28155
Closed
Merged via the queue into master with commit a1a4c7e Apr 16, 2024
15 checks passed
@KevinDavilaDotCMS KevinDavilaDotCMS deleted the fix/layout-disabled-tooltip-and-contentlet-tools-space branch April 16, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmoreras hmoreras hmoreras approved these changes

@oidacra oidacra oidacra approved these changes

@fmontes fmontes fmontes approved these changes

@rjvelazco rjvelazco Awaiting requested review from rjvelazco

@zJaaal zJaaal Awaiting requested review from zJaaal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Edit Page V2: Edit Contentlet Button Spacing Issue
5 participants
@KevinDavilaDotCMS @fmontes @oidacra @hmoreras @kevindaviladev