Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PP]: Filter option relationships is not being respected #30998

Closed
erickgonzalez opened this issue Dec 20, 2024 · 3 comments · Fixed by #31008
Closed

[PP]: Filter option relationships is not being respected #30998

erickgonzalez opened this issue Dec 20, 2024 · 3 comments · Fixed by #31008

Comments

@erickgonzalez
Copy link
Contributor

erickgonzalez commented Dec 20, 2024

Parent Issue

We need to take care of this first #30997

Problem Statement

Despite setting the option relationships: false in the PP Filter, it continues to both send and modify relationships. This suggests that the filter is not functioning as intended, leading to unexpected behavior in how relationships are handled.

Steps to Reproduce

  1. In the Sender, create a parent Content Type: Parent, and a child Content Type: Child, with a Title field
  2. In the Parent type, add a Relationships Field pointing to the Child type with a many-to-many cardinality.
  3. Create a Contentlet of type Child named My Child Content
  4. Create a Contentlet of type Parent named My Parent Content and relate the My Child Content to it.
  5. Push publish My Parent Content — the parent — to the Receiver. The Receiver must have those two new Contentlets now
  6. In the Receiver, create a new Parent contentlet: My Second Parent Content, and relate the pushed My Child Content to it. So now, in the Receiver, My Child Content has two parents.
  7. Go back to the Sender, and delete all Push Publishing history via the Maintenance portlet.
  8. From the Sender, push publish the My Child Content now — notice that you pushed the parent Contentlet last time using the Only Selected Items filter.
  9. Go to the Receiver and check both My Parent Content and My Second Parent Content — the content you manually created in the Receiver. This time, the My Second Parent Content will NOT have its reference to the My Child Content.

Acceptance Criteria

If in the filter Relationships = True:
• The Bundler should include relationship information (table tree) in the bundle.
• The Handler should clean current relationships and populate them with the data from the bundle.
If in the filter Relationships = False:
• The Bundler should exclude relationship information.
• The Handler should not modify existing relationships in the table tree, preserving the current relationships on the receiver.

We need to document this new behavior since it will affect PP globally.

dotCMS Version

23.01 LTS
Demo

Proposed Objective

Customer Success

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@jcastro-dotcms jcastro-dotcms moved this from Next 1-3 Sprints to In Review in dotCMS - Product Planning Dec 24, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 27, 2024
…t being respected (#31008)

### Proposed Changes
* Passing down the Push Publishing Filter that was used when generating
the bundle that is being sent to the receiving endpoints.
* When a filter with `relationships: false` is used, DO NOT re-generate
the `tree` table as this may also clear relationships of the specified
content with parents that we don't have records of at that point.

---------

Co-authored-by: erickgonzalez <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Done in dotCMS - Product Planning Dec 27, 2024
@erickgonzalez erickgonzalez moved this from Done to Internal QA in dotCMS - Product Planning Dec 27, 2024
@erickgonzalez
Copy link
Contributor Author

Working as it should, now when using a PP Filter that has relationships: false it won't regenerate the relationships on the receiver.

Screen.Recording.2024-12-27.at.10.20.35.AM.mov

@erickgonzalez erickgonzalez added the LTS: Next Patch Shortlisted of issues that will be included in the upcoming LTS patch label Feb 3, 2025
@erickgonzalez
Copy link
Contributor Author

Another customer: https://dotcms.freshdesk.com/a/tickets/29250

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants