Fix test reports archives not generated on maven failure

[spbolton]

We seem to have an error in the pipeline that is causing test failures not to get generated. Essentially if the maven step fails it is not continuing in the composite action to upload the build-reports-* and build-reports-test-* archive for that step. We need to change the logic in the maven-job action to upload regardless

The build-reports-* is working it is just build-reports-test-*. it is not enough to test in the if for the inputs flag we need to explicitly allow it to run on failure with “if: always() && ${{ inputs.generates-test-results == ‘true’ }}”

• id: generate-build-reports-artifact
  name: Generate Build Reports Artifact
  uses: actions/upload-artifact@v4
  if: always()
  with:
  name: “build-reports-${{ inputs.stage-name }}”
  path: |
  target/build-report.json
  LICENSE
  retention-days: 2
  • id: create-test-reports-artifact
    name: Create Test Reports Artifact
    uses: actions/upload-artifact@v4
    if: ${{ inputs.generates-test-results == ‘true’ }}
    with:
    name: “build-reports-test-${{ inputs.stage-name }}”
    path: |
    **/target/jacoco-report/.exec
    **/target/-reports/TEST-*.xml