Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(edit-content): error with inputs text #29275

Closed
Tracked by #28493
nicobytes opened this issue Jul 18, 2024 · 2 comments · Fixed by #29279
Closed
Tracked by #28493

fix(edit-content): error with inputs text #29275

nicobytes opened this issue Jul 18, 2024 · 2 comments · Fixed by #29279
Assignees
@jcastro-dotcms
Labels
dotCMS : Content Management Merged QA : Approved QA : Passed Internal Release : 24.07.30 GraphQL Schemas Team : Falcon Type : Defect

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Jul 18, 2024 •
edited
Loading

Parent Issue

#28493

User Story

As a user, when you create new content with a text field, focus on that field, and then press Enter, the side menu related to the category field appears, and this behavior is a bug.

2024-07-18.10-35-09.mp4
@nicobytes nicobytes mentioned this issue Jul 18, 2024
Closed
@nicobytes nicobytes self-assigned this Jul 18, 2024
@nicobytes nicobytes moved this from New to In Progress in dotCMS - Product Planning Jul 18, 2024
@nicobytes nicobytes linked a pull request Jul 18, 2024 that will close this issue
chore: Fix error loading the DotCategoryFieldSidebarComponent #29279
Merged
3 tasks
@nicobytes nicobytes mentioned this issue Jul 18, 2024
Merged
3 tasks
@nicobytes nicobytes moved this from In Progress to In Review in dotCMS - Product Planning Jul 18, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 22, 2024
@nicobytes
chore: Fix error loading the DotCategoryFieldSidebarComponent (#29279)
9bee608 
### Parent Issue

#29275

### Proposed Changes
* Add proper typing to changeMode output
* Move the effect to ngOnInit with explicit inject to avoid form control
errors
* Change hasSelectedCategories to a calculated signal
* Add `type=button` in category button to avoid events with other input
fields

### Checklist
- [x] Tests
- [x] Translations
- [x] Security Implications Contemplated (add notes if applicable)

### Additional Info

As a user, when you create new content with a text field, focus on that
field, and then press Enter, the side menu related to the category field
appears, and this behavior is a bug.


https://github.com/user-attachments/assets/95efc9de-1aec-4686-9ded-640ee95f3b84
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Jul 22, 2024
@nicobytes nicobytes changed the title Fix error with inputs text fix(edit-content): error with inputs text Jul 22, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Jul 23, 2024
@jcastro-dotcms jcastro-dotcms moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning Jul 23, 2024
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED

  • Docker Image: nightly_28c6d14

Hitting the Enter key in a text field is not causing the Category slider to show up anymore. Here are my STRs:

  • Create a Content Type with a text field, and a Category field.
  • Create a Contentlet with it.
  • Hit Enter when the cursor is placed in the text field.
  • Nothing happens, which is expected.

@jcastro-dotcms jcastro-dotcms moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jul 23, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jul 24, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_2c23184, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Jul 26, 2024
@github-project-automation github-project-automation bot moved this from Done to Internal QA in dotCMS - Product Planning Jul 30, 2024
@dsilvam dsilvam moved this from Internal QA to Done in dotCMS - Product Planning Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcastro-dotcms jcastro-dotcms

Labels
dotCMS : Content Management Merged QA : Approved QA : Passed Internal Release : 24.07.30 GraphQL Schemas Team : Falcon Type : Defect
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Fix error loading the DotCategoryFieldSidebarComponent dotCMS/core
3 participants
@nicobytes @jcastro-dotcms @josemejias11