Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotCLI : Do not require the dot-service.yml #27799

Closed
Tracked by #28378
wezell opened this issue Mar 1, 2024 · 5 comments · Fixed by #28389
Closed
Tracked by #28378

dotCLI : Do not require the dot-service.yml #27799

wezell opened this issue Mar 1, 2024 · 5 comments · Fixed by #28389
Labels
Doc : Needs Doc dotCMS : CLI LTS: Needs Backport Ticket that will be added to LTS Merged QA : Approved QA : Passed Internal Release : 24.05.13 Bug Fixing Team : Scout Type : Task

Comments

@wezell
Copy link
Contributor

wezell commented Mar 1, 2024 •
edited
Loading

Task

If all the commands can take a token (and do not need a user/creds) then we should also add the ability to specify the DOT_API_URL via the command line. This will save time when someone is trying to use the cli programmatically or just as a one off thing - there wont be a need to make a fake/temp entry into a $HOME/.dotcms/dot-service.yml file.

This would allow us to just use something like the following:

dotcli push  --token=$token --dotcmsUrl=https://demo.dotcms.com
@nollymar nollymar moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Mar 2, 2024
@fabrizzio-dotCMS
Copy link
Contributor

We already have a validation in place that prevents every command from being executed unless the cli has been configured (Meaning that the yml has been created). What should be the flow from now on?
@wezell

@wezell
Copy link
Contributor Author

wezell commented Mar 4, 2024 •
edited
Loading

We should not need a yml to run the command line. If all the needed switches needed are passed to the cli, it should work.

It seems like the --token and the --dotcmsUrl satisfy everything that is needed to run from the command line.

@nollymar
Copy link
Contributor

nollymar commented Mar 4, 2024

I think we need to have a further discussion about this requirement. @spbolton pointed out some aspects here that I think are important to consider as well.

@jgambarios jgambarios self-assigned this Apr 24, 2024
@jgambarios jgambarios moved this from Next 1-3 Sprints to In Progress in dotCMS - Product Planning Apr 24, 2024
@damen-dotcms damen-dotcms mentioned this issue Apr 29, 2024
Closed
jgambarios added a commit that referenced this issue Apr 29, 2024
@jgambarios
#27799 Adding support for a dotCMS URL and bypass the yml file config…
8ab210f 
…uration
jgambarios added a commit that referenced this issue Apr 30, 2024
@jgambarios
#27799 Adding support for a dotCMS URL and bypass the yml file config…
3ffb1d6 
…uration
jgambarios added a commit that referenced this issue May 1, 2024
@jgambarios
#27799 Adding support for a dotCMS URL and bypass the yml file config…
758ad16 
…uration
jgambarios added a commit that referenced this issue May 1, 2024
@jgambarios
#27799 Fixing IT
36c0145
@jgambarios jgambarios linked a pull request May 1, 2024 that will close this issue
Issue 27799 dot cli do not require the dot service yml #28389
Merged
jgambarios added a commit that referenced this issue May 1, 2024
@jgambarios
#27799 Applying sonarlint feedback
d2a1eff
jgambarios added a commit that referenced this issue May 1, 2024
@jgambarios
#27799 Renaming test class
144dbfd
jgambarios added a commit that referenced this issue May 1, 2024
@jgambarios
#27799 Handling nulls
3bb55d0
jgambarios added a commit that referenced this issue May 1, 2024
@jgambarios
#27799 Improving cleanup in IT
1035abd
@nollymar nollymar moved this from In Progress to In Review in dotCMS - Product Planning May 1, 2024
jgambarios added a commit that referenced this issue May 2, 2024
@jgambarios
#27799 Implemented Resetable interface in API models
1154b65 
Added a new Resetable interface and implemented it in the AuthenticationParam and RemoteURLParam classes. This implementation standardized the way objects reset to their original state across the API models. As a result, removed the reset method from these classes as it's now inherited from the Resetable interface.
github-merge-queue bot pushed a commit that referenced this issue May 2, 2024
@jgambarios
Issue 27799 dot cli do not require the dot service yml (#28389)
1e05f0e 
* #27799 Adding support for a dotCMS URL and bypass the yml file configuration

* #27799 Adding support for a dotCMS URL and bypass the yml file configuration

* #27799 Adding support for a dotCMS URL and bypass the yml file configuration

* #27799 Fixing IT

* #27799 Applying sonarlint feedback

* #27799 Renaming test class

* #27799 Handling nulls

* #27799 Improving cleanup in IT

* #27799 Implemented Resetable interface in API models

Added a new Resetable interface and implemented it in the AuthenticationParam and RemoteURLParam classes. This implementation standardized the way objects reset to their original state across the API models. As a result, removed the reset method from these classes as it's now inherited from the Resetable interface.
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning May 2, 2024
@jgambarios jgambarios removed their assignment May 2, 2024
@nollymar nollymar reopened this May 3, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning May 3, 2024
@nollymar nollymar added the Merged label May 3, 2024
@nollymar nollymar moved this from Current Sprint Backlog to Internal QA in dotCMS - Product Planning May 3, 2024
@dcolina dcolina assigned dcolina and unassigned dcolina May 7, 2024
@dcolina
Copy link
Contributor

dcolina commented May 7, 2024

Internal QA: Passed.

As we can see in the following images.

Image
Image

@dcolina dcolina moved this from Internal QA to QA - Backlog in dotCMS - Product Planning May 7, 2024
@nollymar nollymar closed this as completed May 8, 2024
@github-project-automation github-project-automation bot moved this from QA - Backlog to Internal QA in dotCMS - Product Planning May 8, 2024
@nollymar nollymar moved this from Internal QA to QA - Backlog in dotCMS - Product Planning May 8, 2024
@bryanboza
Copy link
Contributor

Fixed, now we are able to override the configuration and target an specific server using the dotcms-url command

Image

@bryanboza bryanboza moved this from QA - Backlog to Done in dotCMS - Product Planning May 8, 2024
@nollymar nollymar added LTS: Needs Backport Ticket that will be added to LTS and removed Triage labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Doc : Needs Doc dotCMS : CLI LTS: Needs Backport Ticket that will be added to LTS Merged QA : Approved QA : Passed Internal Release : 24.05.13 Bug Fixing Team : Scout Type : Task
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 27799 dot cli do not require the dot service yml dotCMS/core
6 participants
@jgambarios @wezell @bryanboza @nollymar @dcolina @fabrizzio-dotCMS