Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSGi/Felix - Discard fragment JARs after upload #26518

Closed
swicken-dotcms opened this issue Oct 25, 2023 · 7 comments · Fixed by #28025 or #28981
Closed

OSGi/Felix - Discard fragment JARs after upload #26518

swicken-dotcms opened this issue Oct 25, 2023 · 7 comments · Fixed by #28025 or #28981
Assignees
@dsilvam
Labels
dotCMS : OSGi OKR : Customer Support Owned by Scott QA : Approved QA : Passed Internal Release : 24.06.26 Bug Fixing Team : Falcon Type : New Functionality

Comments

@swicken-dotcms
Copy link
Contributor

Parent Issue

No response

User Story

As a plugin developer, having the plugin fragments in the undeployed list is confusing. After they have been processed, redeploying them from the undeployed state has no effect as it does not put them through the upload behavior again (reading in packages). Deploying them can actually cause issues with the felix framework starting, as well.

Acceptance Criteria

Discard the fragment after processing
Provide a message to the user letting them know the packages in the fragment have been added to the exported packages list

Proposed Objective

Technical User Experience

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response
@jdotcms jdotcms self-assigned this Oct 25, 2023
@erickgonzalez erickgonzalez moved this from New to Future in dotCMS - Product Planning Oct 26, 2023
jdotcms added a commit that referenced this issue Mar 20, 2024
@jdotcms
#26518 now we remove fragments instead of moving to the updeploy folder
cc46e10
@jdotcms jdotcms linked a pull request Mar 20, 2024 that will close this issue
fix(core): OSGi/Felix - Discard fragment JARs after upload #26518 #28025
Merged
@jdotcms jdotcms moved this from Future to In Review in dotCMS - Product Planning Mar 20, 2024
jdotcms added a commit that referenced this issue Apr 5, 2024
@jdotcms
#26518 adding sonarq feedback
14c0ba3
github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
@jdotcms @fmontes
fix(core): OSGi/Felix - Discard fragment JARs after upload #26518 (#2…
26affeb 
…8025)

* #26518 now we remove fragments instead of moving to the updeploy folder

* #26518 adding sonarq feedback

---------

Co-authored-by: Freddy Montes <[email protected]>
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Apr 16, 2024
@jdotcms
Copy link
Contributor

jdotcms commented Apr 24, 2024

You can use this as a test
header-app.zip

@rjvelazco
Copy link
Contributor

rjvelazco commented May 1, 2024 •
edited
Loading

Failed Internal QA

  • Tested on Docker: [dotcms/trunk_ 2b727f8]

Issue

When adding a fragment we are showing New OSGI Plugins has been installed instead of The packages in the fragment have been added to the exported packages list.

Video

Screen.Recording.2024-05-01.at.4.50.24.PM.mov

@rjvelazco rjvelazco moved this from Internal QA to In Progress in dotCMS - Product Planning May 1, 2024
@jdotcms jdotcms moved this from In Progress to In Review in dotCMS - Product Planning Jun 14, 2024
@fmontes fmontes moved this from In Review to Internal QA in dotCMS - Product Planning Jun 17, 2024
@rjvelazco
Copy link
Contributor

Are there any updates here, @fmontes @jdotcms? Are we going to add the The packages in the fragment have been added to the exported packages list.?

@jdotcms
Copy link
Contributor

jdotcms commented Jun 18, 2024

We do, we imported the packages and then discard

@dsilvam dsilvam assigned dsilvam and unassigned jdotcms Jun 20, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Jun 20, 2024

Failed IQA: This is missing the message requested in the description/acceptance-criteria

@dsilvam dsilvam moved this from Internal QA to In Progress in dotCMS - Product Planning Jun 20, 2024
@dsilvam dsilvam assigned jdotcms and unassigned dsilvam Jun 20, 2024
jdotcms added a commit that referenced this issue Jun 24, 2024
@jdotcms
#26518 addded iqa feedback
6d7f41a
jdotcms added a commit that referenced this issue Jun 24, 2024
@jdotcms
#26518 merge master done
f7bab94
jdotcms added a commit that referenced this issue Jun 24, 2024
@jdotcms
#26518 merge master done
27e1fc1
@github-actions github-actions bot mentioned this issue Jun 24, 2024
Merged
@dsilvam dsilvam moved this from In Progress to Internal QA in dotCMS - Product Planning Jun 24, 2024
@dsilvam
Copy link
Contributor

dsilvam commented Jun 24, 2024

Passed Internal QA: Properly discarding fragment and showing expected message.

Image

@dsilvam dsilvam self-assigned this Jun 24, 2024
@dsilvam dsilvam removed the Triage label Jun 24, 2024
@dsilvam dsilvam moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Jun 24, 2024
@bryanboza bryanboza moved this from QA - Backlog to QA - In Progress in dotCMS - Product Planning Jun 24, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_d04bdd9, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsilvam dsilvam

Labels
dotCMS : OSGi OKR : Customer Support Owned by Scott QA : Approved QA : Passed Internal Release : 24.06.26 Bug Fixing Team : Falcon Type : New Functionality
Projects
dotCMS - Product Planning
Archived in project
Milestone
No milestone
5 participants
@dsilvam @jdotcms @rjvelazco @swicken-dotcms @josemejias11