Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReindexThread Paused logged too frequently #20821

Closed
yasindilekci opened this issue Aug 19, 2021 · 6 comments · Fixed by #20851 or #20928
Closed

ReindexThread Paused logged too frequently #20821

yasindilekci opened this issue Aug 19, 2021 · 6 comments · Fixed by #20851 or #20928

Comments

@yasindilekci
Copy link

yasindilekci commented Aug 19, 2021

Hi,

We have noticed that the log line below is being logged frequently after upgrading dotCMS to 5.2.8.5.

Java class: https://github.com/dotCMS/core/blob/master/dotCMS/src/main/java/com/dotmarketing/common/reindex/ReindexThread.java#L233

Since this is also filling up the logs, we would like to know why this is being logged so frequently and how to reduce this? We could modify the REINDEX_THREAD_PAUSE_IN_MINUTES property, however this will also affect other methods used by the ReindexThread.

Thank you

[12/08/21 12:07:45:264 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:07:51:269 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:07:57:275 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:03:781 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:09:787 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:15:792 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:21:798 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:27:803 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:34:309 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:40:314 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:46:321 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:52:326 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:08:58:330 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:04:834 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:10:838 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:16:842 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:22:847 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:28:852 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:35:357 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:41:363 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:47:367 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:53:373 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:09:59:379 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:10:05:884 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:10:11:889 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:10:17:891 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis) [12/08/21 12:10:23:895 BST] INFO reindex.ReindexThread: --- ReindexThread Paused (every 3600000 millis)

@fabrizzio-dotCMS
Copy link
Contributor

Changed the prop REINDEX_THREAD_PAUSE_IN_MINUTES to use different values the message is printed accordingly it does not go out of synch

@bryanboza
Copy link
Member

Fixed, tested with a custom data set upgrading from 5.2.x to the release branch and works as expected

@rweiner rweiner added Changelog: Skip Not customer facing and never seen by customers issues Changelog: Documented and removed Changelog: Skip Not customer facing and never seen by customers issues labels Sep 2, 2021
@fabrizzio-dotCMS fabrizzio-dotCMS self-assigned this Sep 3, 2021
fabrizzio-dotCMS added a commit that referenced this issue Sep 4, 2021
@fabrizzio-dotCMS fabrizzio-dotCMS linked a pull request Sep 4, 2021 that will close this issue
@wezell wezell modified the milestones: Maintenance Sprint, Scout Current Sep 7, 2021
@wezell
Copy link
Contributor

wezell commented Sep 7, 2021

Instead of much of this work, we should re-implement our ExpiringMap using caffeine's native function for this behavior:
see:
ben-manes/caffeine#114
https://stackoverflow.com/questions/61721386/caffeine-cache-specify-expiry-for-an-entry

@wezell wezell modified the milestones: Scout Current, Falcon Current Sep 7, 2021
nollymar pushed a commit that referenced this issue Sep 10, 2021
@nollymar
Copy link
Contributor

@fabrizzio-dotCMS 's fix was merged (#20928) . In a future release, @wezell 's suggestion (#20821 (comment)) will be implemented

@nollymar
Copy link
Contributor

Internal QA: Passed

@bryanboza
Copy link
Member

Fixed, tested on release-21.10 // Docker // FF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment