now we show dialogs on edit variant (#28292)

dotCMS · Apr 22, 2024 · 38174b1 · 38174b1
1 parent 24eea44
commit 38174b1
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 1 deletion.
diff --git a/...web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.html b/...web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.html
@@ -101,7 +101,8 @@
         (dragEnd)="onDragEnd($event)"
         data-testId="palette" />
 
-    @if(es.editorData.canEditVariant && es.editorData.mode === editorMode.EDIT) {
+    @if(es.editorData.canEditVariant && (es.editorData.mode === editorMode.EDIT ||
+    es.editorData.mode === editorMode.EDIT_VARIANT)) {
     <dot-edit-ema-dialog
         #dialog
         (action)="onCustomEvent($event)"

diff --git a/.../libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.spec.ts b/.../libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.spec.ts
@@ -1791,6 +1791,29 @@ describe('EditEmaEditorComponent', () => {
                 expect(confirmDialog.getAttribute('acceptIcon')).toBe('hidden');
                 expect(confirmDialog.getAttribute('rejectIcon')).toBe('hidden');
             });
+
+            it('should show the dialogs when we can edit a variant', () => {
+                const componentsToHide = ['dialog', 'confirm-dialog']; // Test id of components that should hide when entering preview modes
+
+                spectator.detectChanges();
+
+                spectator.activatedRouteStub.setQueryParam('variantName', 'hello-there');
+
+                spectator.detectChanges();
+                store.load({
+                    url: 'index',
+                    language_id: '5',
+                    'com.dotmarketing.persona.id': DEFAULT_PERSONA.identifier,
+                    variantName: 'hello-there',
+                    experimentId: 'i have a variant'
+                });
+
+                spectator.detectChanges();
+
+                componentsToHide.forEach((testId) => {
+                    expect(spectator.query(byTestId(testId))).not.toBeNull();
+                });
+            });
         });
 
         describe('move contentlet', () => {