Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response should only contain correct items with code and display #60

Closed
2 tasks done
cheyer opened this issue Sep 21, 2023 · 0 comments · Fixed by #63 or #64
Closed
2 tasks done

Response should only contain correct items with code and display #60

cheyer opened this issue Sep 21, 2023 · 0 comments · Fixed by #63 or #64
Assignees
@velramiir

Comments

@cheyer
Copy link
Contributor

cheyer commented Sep 21, 2023 •
edited by velramiir
Loading

🚀 Feature Description

As a API user I do not want to get items that are incomplete.

✔ Acceptance Criteria

  • API returns only complete items containing code and display
  • service should log error if incomplete items exist / are returned
@velramiir velramiir mentioned this issue Sep 26, 2023
Merged
4 tasks
@velramiir velramiir linked a pull request Sep 26, 2023 that will close this issue
feat: return only complete codesystem concepts #63
Merged
4 tasks
dotbase-bot pushed a commit that referenced this issue Sep 27, 2023
@velramiir
feat: return only complete codesystem concepts
0433ad1 
# Ticket 🎫

This closes #60.

# Description 📖
This filters the search results for presence of the properties `code` and `display` and logs a warning if incomplete concepts are found.

# How to Test? 🧪

Remove a code or a display property from the ICD-10 CodeSystem and search for this code. It should not appear in the search results anymore. A warning should be logged by the API.

# Checklist ✅
- [x] My changes generate no new warnings
- [x] Made corresponding changes to the documentation if applicable
- [x] Commented my code, particularly in hard-to-understand areas if applicable
- [x] Performed a self-review of my own changes
@dotbase-bot dotbase-bot mentioned this issue Sep 27, 2023
Merged
dotbase-bot added a commit that referenced this issue Sep 27, 2023
@dotbase-bot
chore(release): v4.0.0
805aaf8 
### ⚠ BREAKING CHANGES

* This PR introduces the latest 2023 release for ICD-10-GM . 🚨

### 🚀 New Features

* return only complete codesystem concepts ([0433ad1](0433ad1)), closes [#60](#60)
* update icd-10 to 2023 release ([cd4b48d](cd4b48d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@velramiir velramiir

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cheyer @velramiir @andreakreichgauer