Fix incorrect line endings #247
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. I will test it manually and if it works will approve |
|
Actually, I probably made a mistake while testing this issue because for some reason I am not able to reproduce this either by building it myself or using the aur packages. I'm not sure how I got it in the first place, I'll try to provide some instructions on how to reproduce (if I manage to do it), otherwise you are very free to ignore this PR, sorry for the trouble. |
|
Turns out that, citing the go spec
so this fix isn't really fixing anything. I'll close this PR and do some further investigation and if i manage to reproduce it I'll update the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #246 for context.
It's not very pretty but it works.
Closes #246