Allow shareProcessNamespace in pod manifests #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaniwaki
force-pushed
the
set-share-process-namespace
branch
from
9b40533 to
2b941c6
Compare
dtaniwaki
force-pushed
the
set-share-process-namespace
branch
from
2b941c6 to
5e5ceeb
Compare
|
LGTM - thanks for the PR (and sorry for delay) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Kubernetes 1.12,
shareProcessNamespaceis available in pod manifests.https://kubernetes.io/docs/tasks/configure-pod-container/share-process-namespace/
Could you merge this PR so we can use the flag through skuber?