Bump dora to version 0.3.8 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-opp
reviewed
Dec 10, 2024
Changelog.md
Outdated
| * Add yuv420 encoding to opencv-video-capture by @haixuanTao in https://github.com/dora-rs/dora/pull/725 | ||
| * Change macOS CI runner to `macos-13` by @phil-opp in https://github.com/dora-rs/dora/pull/729 | ||
| * Add eyre to pyo3 node by @haixuanTao in https://github.com/dora-rs/dora/pull/730 | ||
| * Moving queue size and making node flume queue bigger by @haixuanTao in https://github.com/dora-rs/dora/pull/724 |
There was a problem hiding this comment.
This PR seems to also include the new scheduler. We should mention this separately.
Also, the new scheduler is a breaking change since it changes the order of events observed by nodes. So nodes that relied on the order (or on monotonically increasing event timestamps) might behave differently after this change. The proper way to handle this would be to bump the version to v0.4.0, but I'm not sure if that is desired. Either way, we need to be a bit more careful with this change and add at least a warning about the behavior change to the changelog.
|
I have added a phrase within the changelog on breaking change. |
haixuanTao
force-pushed
the
bump-dora-v0.3.8
branch
from
0a21b33 to
8ee9e2b
Compare
haixuanTao
force-pushed
the
bump-dora-v0.3.8
branch
from
b2601de to
21a99ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.