Publish rust project on pip to make it simpler to deploy dora node on different machine without requiring installing cargo #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haixuanTao
force-pushed
the
pip-release-cargo-project
branch
from
ec0ef95 to
9ae7467
Compare
phil-opp
approved these changes
Oct 31, 2024
haixuanTao
added a commit
that referenced
this pull request
Nov 11, 2024
This PR makes dora-cli pip installable with ```bash pip install dora-rs-cli ``` This is a pretty big deal to make pre-compiled dora-cli easily available in China, where pip is widely mirrored It fixes some abi3 issues from #695 such as not being a cdylib and python project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently rust node and the cli requires easier to use cargo or wget, but it would be simpler if we could just pip install them.
This PR do this.
People will be able to do:
This will make the pull process of nodes simpler for people who only use python.