Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new node syntax for examples dataflow #643

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

Hennzau
Copy link
Collaborator

@Hennzau Hennzau commented Aug 30, 2024

Hi! I took a look at our examples directory, and while reading through some dataflows, I noticed that there are a lot of outdated node syntaxes:

nodes:
  - id: rust-node
    custom:
      build: cargo build -p benchmark-example-node --release
      source: ../../target/release/benchmark-example-node

I think it would be better if we avoided using deprecated syntax in our example folder, as it will be one of the first things people look at.

@Hennzau Hennzau requested a review from haixuanTao August 30, 2024 21:32
Copy link
Collaborator

@haixuanTao haixuanTao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely!

Thanks!

@haixuanTao haixuanTao merged commit e3ec7fb into main Aug 31, 2024
40 checks passed
@haixuanTao haixuanTao deleted the rework_examples branch August 31, 2024 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants