Remove dynamic node from pending nodes before starting a dataflow #606
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a dataflow start independently from dynamic nodes.
Previously, all nodes wait for each other to be ready before starting the dataflow, this makes it possible to have synchronised messages, and avoid feeling up queues before the nodes is even ready to receive message. I think in the case of dynamic node, we don't want to wait for users to spawn the nodes to start the dataflow.
This creates the possibility to specify some nodes that can "tap" on the dataflow as well as remove the risk of having race condition if dynamic nodes needs to be specified in a specific order.
One recent example is RJ wanting to have multiple nodes within one python process and this was not possible due to nodes being pending.