-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domain unix socket supports #594
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, looks very good overall!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick update!
So, on my local test, I didn't see any difference in performance running dora-benchmark. Wonder if this makes a difference on very specialized hardware. |
I also did a test, got the same result. It's wired. In theory, it should be more efficient than Tcp socket. More details. the following is UnixStream with
the following is UnixStream
the following is TcpStream
|
The overhead of TCP headers etc is probably small enough to not matter too much in our case. One of the comments in the stackoverflow post you linked reported 6us latency for TCP and 2us latency for Unix domain sockets. We have latencies of at least 400us, so the 4us difference don't matter much. |
The unix domain socket is more efficient than TCP socket in local linux machine.
The PR add support to unix domain socket.