Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add a comment on read_dora_input_id #580

Merged
merged 3 commits into from
Jul 11, 2024
Merged

add a comment on read_dora_input_id #580

merged 3 commits into from
Jul 11, 2024

Conversation

XxChang
Copy link
Collaborator

@XxChang XxChang commented Jul 9, 2024

String is not a null-terminated string which is very different from C-type string. We should mention it.

See #577

EricLBuehler
EricLBuehler reviewed Jul 9, 2024
View reviewed changes
apis/c/node/src/lib.rs Outdated Show resolved Hide resolved
phil-opp
phil-opp approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@phil-opp phil-opp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@phil-opp phil-opp merged commit 6d3638e into main Jul 11, 2024
18 checks passed
@phil-opp phil-opp deleted the add_comment branch July 11, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricLBuehler EricLBuehler EricLBuehler left review comments

@phil-opp phil-opp phil-opp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XxChang @phil-opp @EricLBuehler