-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dora-Message is not independant from dora-core
crate which create conflict when trying to publish a new dora version
#708
Comments
Interesting! I think in this specific case the issue only occurs because you're trying to publish a pre-release, which is not valid for the However, we should be able to do pre-releases and the tight coupling of |
I mean from the error message:
|
I'm currently working on moving more stuff to dora message to avoid the dependency on dora core, so this should be properly fixed soon.
Normal cargo dependencies are not pinned. They are equivalent to a A 0.3.7 release would be sever-compatible, so this specific error should not happen if we released 0.3.7 directly. However, as notes above, we want to be able to do pre-releases, so I'm working on a proper fix. |
Make `dora-message` a dependency of `dora-core`, instead of the other way around. This way, we can continue to freely bump the version of `dora-core` with the other workspace crates, without introducing errors such as #708.
Describe the bug
Currently
dora-message
depends on a fixed version ofdora-core
which means that publishing a new version ofdora
with requirement on newly addeddora-core
version will conflict with the pinneddora-core
version of `dora-message.Related to: #614
TODO:
We need to make dora-message independant from
dora-core
if we want to publish a new version of dora.To Reproduce
Check: https://github.com/dora-rs/dora/actions/runs/11664027456/job/32473707635
The text was updated successfully, but these errors were encountered: