Removing coordinator_addr for run_dataflow command

dora-rs · Jan 19, 2024 · b79172c · b79172c
1 parent eadf6b3
commit b79172c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/binaries/cli/src/main.rs b/binaries/cli/src/main.rs
@@ -275,13 +275,14 @@ fn run() -> eyre::Result<()> {
                 match run_dataflow {
                     Some(dataflow_path) => {
                         tracing::info!("Starting dataflow `{}`", dataflow_path.display());
+                        if let Some(coordinator_addr) = coordinator_addr {
+                            tracing::info!(
+                                "Not using coordinator addr {} as `run_dataflow` is for local dataflow only. Please use the `start` command for remote coordinator",
+                                coordinator_addr
+                            );
+                        }
 
-                        Daemon::run_dataflow(
-                            &dataflow_path,
-                            coordinator_addr,
-                            machine_id.unwrap_or_default(),
-                        )
-                        .await
+                        Daemon::run_dataflow(&dataflow_path).await
                     }
                     None => {
                         let addr = coordinator_addr.unwrap_or_else(|| {

diff --git a/binaries/daemon/src/lib.rs b/binaries/daemon/src/lib.rs
@@ -116,11 +116,7 @@ impl Daemon {
         .map(|_| ())
     }
 
-    pub async fn run_dataflow(
-        dataflow_path: &Path,
-        coordinator_addr: Option<SocketAddr>,
-        machine_id: String,
-    ) -> eyre::Result<()> {
+    pub async fn run_dataflow(dataflow_path: &Path) -> eyre::Result<()> {
         let working_dir = dataflow_path
             .canonicalize()
             .context("failed to canoncialize dataflow path")?
@@ -160,8 +156,8 @@ impl Daemon {
         });
         let run_result = Self::run_general(
             Box::pin(coordinator_events),
-            coordinator_addr,
-            machine_id,
+            None,
+            "".to_string(),
             Some(exit_when_done),
             clock,
         );