Skip to content

Commit

Permalink
Fix macos 14 yolo error (#696)
Browse files Browse the repository at this point in the history
This is a quick CI/CD fix from:
- macos 14 version bump
- node-hub no more space error
  • Loading branch information
haixuanTao authored Oct 31, 2024
2 parents c6e70c2 + 4477d71 commit 0b48837
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 4 deletions.
10 changes: 7 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ jobs:

- name: "Check"
run: cargo check --all
- name: "Build (Without Python node as it is build with maturin)"
run: cargo build --all --exclude dora-node-api-python
- name: "Build (Without Python dep as it is build with maturin)"
run: cargo build --all --exclude dora-node-api-python --exclude dora-operator-api-python --exclude dora-ros2-bridge-python
- name: "Test"
run: cargo test --all --exclude dora-ros2-bridge-python
run: cargo test --all --exclude dora-node-api-python --exclude dora-operator-api-python --exclude dora-ros2-bridge-python

# Run examples as separate job because otherwise we will exhaust the disk
# space of the GitHub action runners.
Expand Down Expand Up @@ -295,6 +295,10 @@ jobs:
dora stop --name ci-rust-dynamic --grace-duration 5s
dora destroy
- uses: actions/setup-python@v2
with:
# TODO: Support Python 3.13 when https://github.com/pytorch/pytorch/issues/130249 is fixed
python-version: "3.12"
- name: "Test CLI (Python)"
timeout-minutes: 30
# fail-fast by using bash shell explictly
Expand Down
32 changes: 32 additions & 0 deletions .github/workflows/node-hub-ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,22 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v2
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
if: runner.os == 'Linux'
with:
# this might remove tools that are actually needed,
# if set to "true" but frees about 6 GB
tool-cache: true

# all of these default to true, but feel free to set to
# "false" if necessary for your workflow
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: true

- name: Set up Python
uses: actions/setup-python@v2
Expand Down Expand Up @@ -48,6 +64,22 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v2
- name: Free Disk Space (Ubuntu)
uses: jlumbroso/free-disk-space@main
if: runner.os == 'Linux'
with:
# this might remove tools that are actually needed,
# if set to "true" but frees about 6 GB
tool-cache: true

# all of these default to true, but feel free to set to
# "false" if necessary for your workflow
android: true
dotnet: true
haskell: true
large-packages: false
docker-images: true
swap-storage: true

- name: Set up Python
uses: actions/setup-python@v2
Expand Down
2 changes: 1 addition & 1 deletion node-hub/dora-yolo/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ packages = [{ include = "dora_yolo" }]
[tool.poetry.dependencies]
dora-rs = "^0.3.6"
numpy = "< 2.0.0"
ultralytics = "<= 8.2.52"
ultralytics = "^8.3.24"
python = "^3.7"

[tool.poetry.scripts]
Expand Down

0 comments on commit 0b48837

Please sign in to comment.