protect against the scenario when langlinks is undefined #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some pages, the langlinks property is undefined, and the current implementation throws an error. An example:
```
import wiki from 'wikipedia'
const pageObj = await wiki.page('TheBrain')
const langLinks = await pageObj.langLinks()
```
throws the error:
```
linksError: linksError: TypeError: Cannot read properties of undefined (reading 'map')
at Page.langLinks (...node_modules\wikipedia\dist\page.js:234:23)
```
This PR is so that langLinks() returns an empty array rather than throws an error
|
Thanks for the PR @yg-i - it makes sense considering the sheer number of languages wikipedia supports that we should have this validation. |
dopecodez
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some pages, the langLinks property is undefined, and the current implementation throws an error. An example:
throws the error:
This PR is so that langLinks() returns an empty array rather than throws an error.