ToValue doesn't convert time.Time to JS Date

[slinkydeveloper]

As in the issue title, I stumbled on this issue where i'm trying to set a time.Time as variable in the engine:

func TestDate(t *testing.T) {
	vm := goja.New()
	vm.Set("time", time.Now())
	res, err := vm.RunString("time.getFullYear()")
	require.NoError(t, err)
	require.Equal(t, 2020, res.ToInteger())
}

=== RUN   TestDate
    filter_engine_test.go:44: 
        	Error Trace:	filter_engine_test.go:44
        	Error:      	Received unexpected error:
        	            	TypeError: Object has no member 'getFullYear' at <eval>:1:17(3)
        	Test:       	TestDate
--- FAIL: TestDate (0.00s)

[dop251]

Please see #72

[slinkydeveloper]

Thank you!

[slinkydeveloper]

I'm trying to use vm.New(vm.GlobalObject().Get("Date").ToObject(vm), vm.ToValue(t.Unix())) from golang side to create a Date (so i can then feed the runtime with Set), but that doesn't seem to work. Or better, i get a date which is empty... Is there something i'm overlooking?

[dop251]

Sorry, I forgot that Unix() returns seconds and the Date constructor requires milliseconds. So, you need t.UnixNano()/1e6

[slinkydeveloper]

That works fine, thanks! What about documenting it somewhere (like in the readme)? I can pr it if you want to