Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remove just sleep and add polling to check drcf loaded #144

Merged

Conversation

leeminju531
Copy link
Contributor

Problem

In hw_interface, we added a sleep as a workaround to ensure the server is fully loaded.
However, this introduces two side effects:

(a) Unnecessary wait: Even if the server is already loaded, the system still waits for the sleep time.
(b) Potential failure due to resource limitations: In cases of limited resources, users may experience failures if the sleep time is exceeded. (related to #142 (comment))

Proposed Solutions.

  1. Use a polling pattern with minimal sleep: This will help address issue (a), as the connection will be attempted at regular intervals with shorter wait times, avoiding unnecessary delays.
  2. IExtend the total timeout (from 8 seconds to 30 seconds): This will address issue (b) by providing enough time for the server to load and ensuring that minor performance delays don’t cause failures.

@doosan-robotics doosan-robotics merged commit 1808c11 into doosan-robotics:humble-devel Jan 7, 2025
1 check passed
This was referenced Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants