Replace Struct subclassing with block-form initialization #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bobziuchkovski! Can you add a note about this in the NEWS.md file? |
|
Hi @bobziuchkovski . What about NEWS.MD? Looks good, but can you add a new entry to changelog? |
|
Seems like there would not be an answer (no topicstarter activity), so I decided to merge it myself. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the Struct subclassing with block-form initialization. According to the the docs, "This is the recommended way to customize a struct. Subclassing an anonymous struct creates an extra anonymous class that will never be used."
This fixes an issue we're seeing downstream in our rails project when using doorkeeper with Spring/Bootsnap. The subclassing pattern results in differing class hierarchies when the code is loaded:
/usr/local/opt/rbenv/versions/2.3.4/gemsets/app/gems/doorkeeper-4.2.0/lib/doorkeeper/oauth/client/credentials.rb:4:in `class:Client': superclass mismatch for class Credentials (TypeError)