Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hooks for ApplicationMetalController #873

Merged
merged 3 commits into from
Aug 9, 2016
Merged

Add hooks for ApplicationMetalController #873

merged 3 commits into from
Aug 9, 2016

Conversation

hongxingshi
Copy link
Contributor

@hongxingshi hongxingshi commented Aug 9, 2016 •
edited
Loading

houndci-bot
houndci-bot reviewed Aug 9, 2016
View reviewed changes
spec/controllers/application_metal_controller.rb
require 'spec_helper_integration'

describe Doorkeeper::ApplicationMetalController do
it 'lazy run hooks' do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@tute
Copy link
Contributor

tute commented Aug 9, 2016

Thanks! Can you please address Hound comments, and add a note to the NEWS file? Thanks!

@tute tute merged commit fffe0ea into doorkeeper-gem:master Aug 9, 2016
@tute
Copy link
Contributor

tute commented Aug 9, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongxingshi @tute @houndci-bot